fix: set period for each split view map #2721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-2721--dhis2-maps.netlify.app |
Passing run #2200 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
jenniferarnesen
approved these changes
Jun 27, 2023
Closed
jenniferarnesen
pushed a commit
that referenced
this pull request
Aug 30, 2023
dhis2-bot
added a commit
that referenced
this pull request
Aug 31, 2023
## [100.1.6](v100.1.5...v100.1.6) (2023-08-31) ### Bug Fixes * **translations:** sync translations from transifex (dev) ([3a3b81e](3a3b81e)) * **translations:** sync translations from transifex (dev) ([3effb0d](3effb0d)) * keep layer visibility when period is changed ([#2705](#2705)) ([df32ea4](df32ea4)) * set period for each split view map ([#2721](#2721)) ([6ec0eba](6ec0eba)) * Set rendering strategy to single if not relative period ([#2703](#2703)) ([c47484b](c47484b)) * upgrade landcover dataset ([#2732](#2732)) ([3e93ced](3e93ced)) * **translations:** sync translations from transifex (dev) ([22d43c7](22d43c7)) * **translations:** sync translations from transifex (dev) ([b5da40a](b5da40a)) * **translations:** sync translations from transifex (dev) ([a090132](a090132)) * **translations:** sync translations from transifex (dev) ([21acc31](21acc31)) * **translations:** sync translations from transifex (dev) ([4597cbb](4597cbb))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure each new split view map gets the correct period when user is drilling down/up.
Fixes: https://dhis2.atlassian.net/browse/DHIS2-15437
After this PR the different periods are kept when drilling:
The PR also fixes some console errors when we try to update a map that has been removed due to user interaction.