Skip to content

Commit

Permalink
MINOR: [Java] Bump com.google.errorprone:error_prone_core from 2.4.0 …
Browse files Browse the repository at this point in the history
…to 2.24.0 in /java (apache#39452)

### Rationale for this change

This is a draft PR for fixing the dependabot PR apache#39409

### What changes are included in this PR?

Upgrading `com.google.errorprone` to 2.24.0 for JDK11+ and restricting `com.google.errorprone` to 2.10 to JDK8. 

### Are these changes tested?

N/A. CIs are implicitly testing this including existing test cases. 

### Are there any user-facing changes?

No

Lead-authored-by: vibhatha <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: David Li <[email protected]>
  • Loading branch information
2 people authored and dgreiss committed Feb 17, 2024
1 parent 293baf5 commit 0966e61
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions java/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
<forkCount>2</forkCount>
<checkstyle.failOnViolation>true</checkstyle.failOnViolation>
<errorprone.javac.version>9+181-r4173-1</errorprone.javac.version>
<error_prone_core.version>2.22.0</error_prone_core.version>
<error_prone_core.version>2.24.0</error_prone_core.version>
<maven-compiler-plugin.version>3.11.0</maven-compiler-plugin.version>
<mockito.core.version>5.5.0</mockito.core.version>
<mockito.inline.version>5.2.0</mockito.inline.version>
Expand Down Expand Up @@ -844,7 +844,7 @@
<path>
<groupId>com.google.errorprone</groupId>
<artifactId>error_prone_core</artifactId>
<version>2.4.0</version>
<version>2.10.0</version>
</path>
</annotationProcessorPaths>
</configuration>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -773,7 +773,7 @@ public void simpleUnion() throws Exception {
for (int i = 0; i < COUNT; i++) {
unionReader.setPosition(i);
if (i % 5 == 0) {
Assert.assertEquals(i, i, unionReader.readInteger());
Assert.assertEquals(i, unionReader.readInteger().intValue());
} else if (i % 5 == 1) {
NullableTimeStampMilliTZHolder holder = new NullableTimeStampMilliTZHolder();
unionReader.read(holder);
Expand Down

0 comments on commit 0966e61

Please sign in to comment.