Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Java] Bump com.google.errorprone:error_prone_core from 2.4.0 to 2.24.0 in /java #39409

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 1, 2024

Bumps com.google.errorprone:error_prone_core from 2.4.0 to 2.24.0.

Release notes

Sourced from com.google.errorprone:error_prone_core's releases.

Error Prone 2.24.0

New checks:

Full Changelog: google/error-prone@v2.23.0...v2.24.0

Error Prone 2.23.0

New checks:

Bug fixes and improvements: #3897, #4114, #4123

Full Changelog: google/error-prone@v2.22.0...v2.23.0

Error Prone 2.22.0

We are considering raising the minimum supported JDK from JDK 11 to JDK 17 in a future release of Error Prone, see #3803. Note that using a newer JDK version to run javac during the build doesn't prevent building code that is deployed to earlier versions, for example it's supported to use the JDK 17 javac and pass --release 11 to compile Java 11 code that is deployed to a JDK 11 runtime. If you have feedback, please comment on #3803.

New checks:

Bug fixes and improvements:

  • Don't complain about literal IP addresses in AddressSelection (google/error-prone@44b6552)
  • Prevent SuggestedFixes#renameMethod from modifying return type declaration (#4043)
  • Fix UnusedVariable false positives for private record parameters (#2713)
  • When running in conservative mode, no longer assume that implementations of Map.get, etc. return null (#2910)
  • CanIgnoreReturnValueSuggester: Support additional exempting method annotations (#4009)
  • UnusedVariable: exclude junit5's @RegisterExtension (#3892)
  • Support running all available patch checks (#947)
  • Upgrade java-diff-utils 4.0 -> 4.12 (#4081)
  • Flag unused Refaster template parameters (#4060)
  • Support @SuppressWarnings("all") (#4065)
  • Prevent Refaster UMemberSelect from matching method parameters (#2456)
  • MissingDefault : Don't require // fall out comments on expression switches (#2709)
  • Skip UnnecessaryLambda findings for usages in enhanced for loops (#2518)
  • Fix bug where nested MissingBraces violations' suggested fixes result in broken code (#3797)

... (truncated)

Commits
  • 2cc8504 Release Error Prone 2.24.0
  • 21c190a Document that javadoc shouldn't appear between annotations and the documented...
  • d272dfa Automated rollback of commit 654d1dbf1e6dd652cd6e8ca003643ddf02266ec2.
  • 654d1db Handle Joiner.on(...) in AbstractToString.
  • da7be27 Descend into VariableTrees when looking for variables to check.
  • affa37a Do not flag unused parameters on abstract methods.
  • d78dd6d Don't report NonFinalStaticField findings for fields modified in `@BeforeClas...
  • aadfdc3 WellKnownThreadSafety: Add common PKIX types to known thread-safe list.
  • ac52ca9 AutoValueFinalMethods: support method-level suppression.
  • 336323a Import eisop/checker-framework from GitHub.
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [com.google.errorprone:error_prone_core](https://github.com/google/error-prone) from 2.4.0 to 2.24.0.
- [Release notes](https://github.com/google/error-prone/releases)
- [Commits](google/error-prone@v2.4.0...v2.24.0)

---
updated-dependencies:
- dependency-name: com.google.errorprone:error_prone_core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from lidavidm as a code owner January 1, 2024 16:23
@dependabot dependabot bot added dependencies Dependabot-only java Dependabot-only labels Jan 1, 2024
@lidavidm
Copy link
Member

lidavidm commented Jan 2, 2024

@vibhatha @davisusanibar can you evaluate what happened here? It seems we should pin to 2.10.0 until we drop Java 8 support (and when we do, we should upgrade to the latest version): https://errorprone.info/docs/installation#jdk-8

Alternatively we should pin 2.10.0 for JDK8 and use the latest version for JDK11+

@vibhatha
Copy link
Collaborator

vibhatha commented Jan 3, 2024

@lidavidm I will take a look.

@vibhatha
Copy link
Collaborator

vibhatha commented Jan 5, 2024

This has been updated here: #39452

lidavidm pushed a commit that referenced this pull request Jan 5, 2024
…to 2.24.0 in /java (#39452)

### Rationale for this change

This is a draft PR for fixing the dependabot PR #39409

### What changes are included in this PR?

Upgrading `com.google.errorprone` to 2.24.0 for JDK11+ and restricting `com.google.errorprone` to 2.10 to JDK8. 

### Are these changes tested?

N/A. CIs are implicitly testing this including existing test cases. 

### Are there any user-facing changes?

No

Lead-authored-by: vibhatha <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: David Li <[email protected]>
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 5, 2024

Superseded by #39474.

@dependabot dependabot bot closed this Jan 5, 2024
@dependabot dependabot bot deleted the dependabot/maven/java/com.google.errorprone-error_prone_core-2.24.0 branch January 5, 2024 15:20
clayburn pushed a commit to clayburn/arrow that referenced this pull request Jan 23, 2024
…to 2.24.0 in /java (apache#39452)

### Rationale for this change

This is a draft PR for fixing the dependabot PR apache#39409

### What changes are included in this PR?

Upgrading `com.google.errorprone` to 2.24.0 for JDK11+ and restricting `com.google.errorprone` to 2.10 to JDK8. 

### Are these changes tested?

N/A. CIs are implicitly testing this including existing test cases. 

### Are there any user-facing changes?

No

Lead-authored-by: vibhatha <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: David Li <[email protected]>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…to 2.24.0 in /java (apache#39452)

### Rationale for this change

This is a draft PR for fixing the dependabot PR apache#39409

### What changes are included in this PR?

Upgrading `com.google.errorprone` to 2.24.0 for JDK11+ and restricting `com.google.errorprone` to 2.10 to JDK8. 

### Are these changes tested?

N/A. CIs are implicitly testing this including existing test cases. 

### Are there any user-facing changes?

No

Lead-authored-by: vibhatha <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: David Li <[email protected]>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this pull request Feb 28, 2024
…to 2.24.0 in /java (apache#39452)

### Rationale for this change

This is a draft PR for fixing the dependabot PR apache#39409

### What changes are included in this PR?

Upgrading `com.google.errorprone` to 2.24.0 for JDK11+ and restricting `com.google.errorprone` to 2.10 to JDK8. 

### Are these changes tested?

N/A. CIs are implicitly testing this including existing test cases. 

### Are there any user-facing changes?

No

Lead-authored-by: vibhatha <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: David Li <[email protected]>
kou pushed a commit to apache/arrow-java that referenced this pull request Nov 25, 2024
…to 2.24.0 in /java (#39452)

### Rationale for this change

This is a draft PR for fixing the dependabot PR apache/arrow#39409

### What changes are included in this PR?

Upgrading `com.google.errorprone` to 2.24.0 for JDK11+ and restricting `com.google.errorprone` to 2.10 to JDK8. 

### Are these changes tested?

N/A. CIs are implicitly testing this including existing test cases. 

### Are there any user-facing changes?

No

Lead-authored-by: vibhatha <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: David Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review Awaiting review Component: Java dependencies Dependabot-only java Dependabot-only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants