graphql: Fix response for partial admin queries. #5317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelJCompton
approved these changes
Apr 28, 2020
There was a problem hiding this comment.
Looks fine.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @abhimanyusinghgaur, @manishrjain, and @MichaelJCompton)
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 18, 2020
Handle `[]map[string]interface{}` separately from `[]interface{}` in `completObject` function. This fixes the bug where admin queries returned full info even when asked for partial information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@martinmr pointed as part of #5307 that partial backup queries were not working. On inspection, I found out that partial admin queries are broken after the refactoring that happened as part of simplifying how resolver are written. The reason being that
[]interface{}is different from[]map[string]interface{}. We also didn't have any test which did partial queries. I have added a test for the same and have a fix in place.This change is