Add GraphQL admin endpoint to list backups. #5307
Conversation
|
@pawanrawal For some reason I cannot get partial queries to work. Even if I query for only one field, I am getting the entire response back. I suspect it's because I am returning a list instead of a map but I am not sure. The schema seems to work fine and the graphql recognizes all the fields. Somehow, they are not being used and I end up with all the data. Could you look at the code in graphql/admin and see if I am doing something wrong? Thanks. |
There was a problem hiding this comment.
Reviewable status: 0 of 11 files reviewed, 1 unresolved discussion (waiting on @manishrjain, @martinmr, and @pawanrawal)
worker/backup_handler.go, line 1 at r2 (raw file):
// +build !oss
Can't do this.
There was a problem hiding this comment.
Reviewable status: 0 of 11 files reviewed, 1 unresolved discussion (waiting on @manishrjain and @pawanrawal)
worker/backup_handler.go, line 1 at r2 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
Can't do this.
Done.
There was a problem hiding this comment.
Reviewed 6 of 10 files at r2, 4 of 6 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @martinmr and @pawanrawal)
graphql/admin/list_backups.go, line 1 at r3 (raw file):
package admin
License?
You'd need !oss flag?
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @manishrjain and @pawanrawal)
graphql/admin/list_backups.go, line 1 at r3 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
License?
You'd need !oss flag?
Done.
The flag is not needed here. The code in the worker package already has that flag. Doing this in the oss version will return an error saying the feature is not supported. We do the same with the backup endpoint.
An endpoint to read the backup manifests in the given location. Fixes DGRAPH-1229
An endpoint to read the backup manifests in the given location.
Fixes DGRAPH-1229
This change is
Docs Preview: