Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial Testing for DnD dragged #77

Merged
merged 32 commits into from
Jul 25, 2020
Merged

Add initial Testing for DnD dragged #77

merged 32 commits into from
Jul 25, 2020

Conversation

jalal246
Copy link
Member

No description provided.

@jalal246 jalal246 linked an issue Jul 20, 2020 that may be closed by this pull request
Unable to stimulate DnD in puppeteer #76
Closed
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (dev@5f5b654). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev      #77   +/-   ##
======================================
  Coverage       ?   70.67%           
======================================
  Files          ?       17           
  Lines          ?      358           
  Branches       ?       51           
======================================
  Hits           ?      253           
  Misses         ?       90           
  Partials       ?       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f5b654...07517cf. Read the comment docs.

@jalal246
Copy link
Member Author

jalal246 commented Jul 20, 2020 •
edited
Loading

Find a way to keep the browser open when the test fails? Related issue: argos-ci/jest-puppeteer#130 (comment) Or just keep it open argos-ci/jest-puppeteer#276 (comment)

jalal246
jalal246 commented Jul 22, 2020
View reviewed changes
Copy link
Member Author

@jalal246 jalal246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should close #76

jalal246
jalal246 commented Jul 22, 2020
View reviewed changes
Copy link
Member Author

@jalal246 jalal246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This passes but leads to a bug in moving direction. Elements should move up, which i supposed should be called "the default direction".

jalal246
jalal246 commented Jul 23, 2020
View reviewed changes
Copy link
Member Author

@jalal246 jalal246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed but list order should be updated

@jalal246 jalal246 added the enhancement New feature or request label Jul 23, 2020
@jalal246 jalal246 changed the title Testing dragged Add initial Testing for DnD dragged Jul 25, 2020
@jalal246 jalal246 merged commit 2f4f7ca into dev Jul 25, 2020
@jalal246 jalal246 mentioned this pull request Jul 27, 2020
Merged
19 tasks
@jalal246 jalal246 deleted the test/e2e/dnd/draggable branch January 8, 2021 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to stimulate DnD in puppeteer
2 participants
@jalal246 @codecov-commenter