Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic comprehensive DnD release #74

Merged
merged 185 commits into from
Aug 19, 2020
Merged

Epic comprehensive DnD release #74

merged 185 commits into from
Aug 19, 2020

Conversation

jalal246
Copy link
Member

@jalal246 jalal246 commented Jul 13, 2020

Branch tasks:

jalal246 added 22 commits July 10, 2020 00:49
This going to facilitate testing and documentation
* import instances form utils file

* Add fake instances to test utils

* Add DnD sub-packages as a new workspace

* Add DnD store as a separate package

This going to facilitate testing and documentation

* Update store importing in different packages

* Init tests for draggable

* creating a droppable instance

* Add first test case

* Fix test in draggable

* Add patch to a description

* Fix aligning elements in test utils instead of stacking above each other

* Add spy as a better approach for testing effected methods and flags and found a bug in moving out horizontally.

* Avoid excessive use of flags

* Add isMovingHorizontally and related effects

* Remove motions tests until add parent
Add parent calculations to dragged
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2020

Codecov Report

Merging #74 into master will decrease coverage by 9.76%.
The diff coverage is 25.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
- Coverage   70.93%   61.16%   -9.77%     
==========================================
  Files          16       17       +1     
  Lines         344      412      +68     
  Branches       45       64      +19     
==========================================
+ Hits          244      252       +8     
- Misses         87      131      +44     
- Partials       13       29      +16     
Impacted Files Coverage Δ
packages/dnd/src/DnDStore/DnDStoreImp.js 100.00% <ø> (ø)
packages/dnd/src/Droppable/Droppable.js 0.00% <0.00%> (ø)
packages/coreInstance/src/CoreInstance.js 36.95% <3.84%> (-2.18%) ⬇️
packages/dnd/src/Draggable/Draggable.js 61.81% <42.85%> (ø)
packages/dnd/src/Draggable/Base.js 93.87% <100.00%> (ø)
packages/dnd/src/Draggable/test/utils.js 100.00% <100.00%> (ø)
packages/store/src/Store.js 100.00% <100.00%> (ø)
packages/store/src/Tracker.js 100.00% <100.00%> (ø)
scripts/dflex-utils-test/funcs.js 91.30% <100.00%> (ø)
scripts/dflex-utils-test/instances.js 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5354889...782ed22. Read the comment docs.

Trigger parent elements down from the first element (out/in)
…do_2

Add separate methods according to movement
Add new methods according to the dragged position regardless of the parent
Ability to lock/unlock parent
Add ID for each drag operation
Add DnD/Testing occupying multiple positions vertically up
@jalal246 jalal246 merged commit 2234972 into master Aug 19, 2020
@jalal246 jalal246 deleted the dev branch August 19, 2020 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants