-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Epic comprehensive DnD release #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This going to facilitate testing and documentation
…found a bug in moving out horizontally.
* import instances form utils file * Add fake instances to test utils * Add DnD sub-packages as a new workspace * Add DnD store as a separate package This going to facilitate testing and documentation * Update store importing in different packages * Init tests for draggable * creating a droppable instance * Add first test case * Fix test in draggable * Add patch to a description * Fix aligning elements in test utils instead of stacking above each other * Add spy as a better approach for testing effected methods and flags and found a bug in moving out horizontally. * Avoid excessive use of flags * Add isMovingHorizontally and related effects * Remove motions tests until add parent
Add parent calculations to dragged
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
==========================================
- Coverage 70.93% 61.16% -9.77%
==========================================
Files 16 17 +1
Lines 344 412 +68
Branches 45 64 +19
==========================================
+ Hits 244 252 +8
- Misses 87 131 +44
- Partials 13 29 +16
Continue to review full report at Codecov.
|
Trigger parent elements down from the first element (out/in)
…do_2 Add separate methods according to movement
Add new methods according to the dragged position regardless of the parent Ability to lock/unlock parent
Create droppable index method
Debug droppable
Add ID for each drag operation
Add DnD/Testing occupying multiple positions vertically up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch tasks: