Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove named parameters from Reporting page-objects #6043

Merged
merged 2 commits into from
Dec 19, 2024
Merged

refactor: remove named parameters from Reporting page-objects #6043

merged 2 commits into from
Dec 19, 2024

Conversation

yhabib
Copy link
Contributor

@yhabib yhabib commented Dec 19, 2024 •
edited
Loading

Motivation

We want to be consistent and removed named parameters when not necessary.
Addresses this comment: #6032 (comment)

Changes

  • removes named parameters from Reporting related page-objects

Tests

  • Not necessary

Todos

  • Add entry to changelog (if necessary).
    Not necessary

@yhabib yhabib marked this pull request as ready for review December 19, 2024 10:15
@yhabib yhabib requested a review from a team as a code owner December 19, 2024 10:15
@yhabib yhabib added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 8b7598b Dec 19, 2024
31 checks passed
@yhabib yhabib deleted the yhabib/clean-page-objects branch December 19, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dskloetd dskloetd dskloetd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhabib @dskloetd