NNS1-3486: period filter for reporting transactions #6032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhabib
force-pushed
the
NNS1-3486/clean-up-types
branch
from
cbccad8 to
06fb4af
Compare
yhabib
force-pushed
the
NNS1-3486/filter-transactions
branch
2 times, most recently
from
a07715b to
276db08
Compare
yhabib
force-pushed
the
NNS1-3486/filter-transactions
branch
from
276db08 to
0b6204f
Compare
dskloetd
reviewed
Dec 18, 2024
frontend/src/tests/lib/components/reporting/ReportingDateRangeSelector.spec.ts
Outdated
Show resolved
Hide resolved
frontend/src/lib/components/reporting/ReportingTransactionsButton.svelte
Outdated
Show resolved
Hide resolved
frontend/src/tests/page-objects/ReportingDateRangeSelector.page-object.ts
Outdated
Show resolved
Hide resolved
yhabib
commented
Dec 18, 2024
frontend/src/tests/lib/components/reporting/ReportingDateRangeSelector.spec.ts
Outdated
Show resolved
Hide resolved
yhabib
force-pushed
the
NNS1-3486/filter-transactions
branch
from
1d72c17 to
581b2a0
Compare
dskloetd
reviewed
Dec 18, 2024
frontend/src/tests/lib/components/reporting/ReportingDateRangeSelector.spec.ts
Outdated
Show resolved
Hide resolved
frontend/src/tests/lib/components/reporting/ReportingDateRangeSelector.spec.ts
Show resolved
Hide resolved
yhabib
force-pushed
the
NNS1-3486/filter-transactions
branch
from
eb53247 to
34b503e
Compare
dskloetd
approved these changes
Dec 19, 2024
1 task
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 19, 2024
# Motivation We want to be consistent and removed named parameters when not necessary. Addresses this comment: #6032 (comment) # Changes - removes named parameters from Reporting related page-objects # Tests - Not necessary # Todos - [ ] Add entry to changelog (if necessary). Not necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want users to be able to generate three types of reports:
https://qsgjb-riaaa-aaaaa-aaaga-cai.yhabib-ingress.devenv.dfinity.network/reporting/
Changes
periodstate toReportingTransactions. It binds it toReportingDateRangeSelectorso it can be updated, and it passes it down toReportingTransactionsButtonto be used when generating the report.Tests
ReportingTransactionsTodos