Fix: Pushes abandoned SNS to the bottom of the nsAggregatorStore #5918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhabib
changed the title
This was referenced Dec 9, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
…5948) # Motivation This is a follow-up to #5918 regarding the display of SNS projects in the Launchpad section. We aim to sort them in descending order, from newest to oldest. This initial PR introduces a function to sort based on `swapOpenTimestampSeconds`. The subsequent PR will implement the requirements outlined in [NNS-3497](https://dfinity.atlassian.net/jira/software/c/projects/NNS1/boards/333?selectedIssue=NNS1-3497). # Changes - New descending sort function based on SNS summary `swapOpenTimestampSeconds`. # Tests - Unit tests # Todos - [ ] Add entry to changelog (if necessary). Not necessary
1 task
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
# Motivation This is a follow-up to #5918 regarding the display of SNS projects in the Launchpad section. We aim to sort them in descending order, from newest to oldest. https://github.com/user-attachments/assets/7e89bddd-64fc-44f2-badf-752d35b1a773 # Changes - Applies new sort functionality to the Launchpad page - Changes section title to `Latest Launches` # Tests - Unit tests to ensure that the `Projects` component always displays projects from newest to oldest. # Todos - [x] Add entry to changelog (if necessary). Prev: #5948 --------- Co-authored-by: pr-automation-bot-public[bot] <189003650+pr-automation-bot-public[bot]@users.noreply.github.com> Co-authored-by: gix-bot <[email protected]> Co-authored-by: David de Kloet <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
# Motivation Follow up of #5918. It simplifies the process of locating and renaming abandoned projects. # Changes - Simplifies the process of finding and renaming abandoned projects. - Replaces the name and token only if the values differ from the originals. # Tests - Adds unit test to cover new logic # Todos - [ ] Add entry to changelog (if necessary). Not necessary --------- Co-authored-by: pr-automation-bot-public[bot] <189003650+pr-automation-bot-public[bot]@users.noreply.github.com> Co-authored-by: gix-bot <[email protected]> Co-authored-by: David de Kloet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As discussed here and here, we have a situation with the SNS
CYCLES-TRANSFER-STATION. They have decided to change all their metadata, resulting in the name and token being displayed as---.This second PR moves abandoned SNSs to the bottom of both the
nsAggregatorStoreand any alphabetical sort.Changes
"\u200B"to the beginning of the name of an abandoned SNS, so alphabetical sorting pushes them to the end.nsAggregatorStoreby the temporal parameterisAbandoned.Tests
Todos
Prev. PR: #5915