Fix: Adds an override for the name and token.symbol values for abandoned SNS #5915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhabib
commented
Dec 4, 2024
dskloetd
reviewed
Dec 4, 2024
yhabib
force-pushed
the
yhabib/fix/rogue-sns
branch
from
548ccab to
f656199
Compare
yhabib
changed the title
1 task
yhabib
force-pushed
the
yhabib/fix/rogue-sns
branch
from
d87cbe7 to
cc43ff1
Compare
dskloetd
approved these changes
Dec 4, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
# Motivation As discussed [here](https://dfinity.slack.com/archives/C03H6QEPW5D/p1733263773416409) and [here](https://dfinity.slack.com/archives/C039M7YS6F6/p1733302975333649), we have a situation with the SNS `CYCLES-TRANSFER-STATION`. They have decided to change all their metadata, resulting in the name and token being displayed as `---`. This second PR moves abandoned SNSs to the bottom of both the `nsAggregatorStore` and any alphabetical sort. # Changes - Adds the hidden character `"\u200B"` to the beginning of the name of an abandoned SNS, so alphabetical sorting pushes them to the end. - Sorts `nsAggregatorStore` by the temporal parameter `isAbandoned`. # Tests - Unit test for the aggregator store derived data to verify that sort functionality works as expected. # Todos - [x] Add entry to changelog (if necessary). Prev. PR: #5915
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As discussed here and here, we have a situation with the SNS
CYCLES-TRANSFER-STATION. They have decided to change all their metadata, resulting in the name and token being displayed as---.This first PR introduces a method to override the values we receive from the SNS-Aggregator, allowing the rest of the application to use them.
Changes
nameandtoken.symbolfor any that are found.Tests
rootCanisterIdis present in the dictionary, the values fornameandtoken.symbolare replaced.Todos