Feat: Add metadata logo path to SNS aggregator data #3301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmuntaner
commented
Sep 12, 2023
lmuntaner
commented
Sep 12, 2023
|
@bitdivine please review I added some questions / comments in the code changes. |
lmuntaner
force-pushed
the
fix_LM_default-sns-logo
branch
from
04ef221 to
d86aa66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The logo to the SNS Metadata needs to be hardcoded by the frontend following a specific pattern.
In this PR, I add the relative path of the logo so that the logic of where the logo lives lies only in the SNS aggregator canister.
Another reason is because the logo is optional. Therefore, this way it's easier to know whether the logo is present or not. Otherwise, we would need to try to fetch the asset and check it.
Changes
logoinSlowMetadata.SlowMetadata::fromto useUpstreamDatato access the root canister id.Tests
Tests are skipped.
Todos