-
Notifications
You must be signed in to change notification settings - Fork 42
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Feat: Add metadata logo path to SNS aggregator data (#3301)
# Motivation The logo to the SNS Metadata needs to be hardcoded by the frontend following a specific pattern. In this PR, I add the relative path of the logo so that the logic of where the logo lives lies only in the SNS aggregator canister. Another reason is because the logo is optional. Therefore, this way it's easier to know whether the logo is present or not. Otherwise, we would need to try to fetch the asset and check it. # Changes * New field `logo` in `SlowMetadata`. * Change `SlowMetadata::from` for `from_get_metadata_response` because it uses a second argument for the logo url. # Tests Tests are skipped. # Todos - [x] Add entry to changelog (if necessary).
- Loading branch information
Showing
2 changed files
with
17 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters