Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI.md: Mention branch protection #2744

Merged
merged 4 commits into from
Aug 24, 2021
Merged

CI.md: Mention branch protection #2744

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a6c2761
CI.md: Mention branch protection
nomeata Aug 23, 2021
e07bdda
Update CI.md
nomeata Aug 23, 2021
1fc4621
Merge branch 'master' into joachim/branch-protection
nomeata Aug 23, 2021
e209374
Merge branch 'master' into joachim/branch-protection
mergify[bot] Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CI.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ Preventing `master` from breaking
**Use-case:**
A PR that breaks requires jobs (`all-systems-go`) cannot be merged into `master`.

**Implementation (internal):**
**Implementation (extenral):**
nomeata marked this conversation as resolved.
Show resolved Hide resolved
Github branch protection is enabled for `master`, and requires the
`all-systems-go` job from hydra to succeed.
Github Action jobs (Linux and Darwin) to succeed.

Require a second pair of eyeballs
---------------------------------
Expand Down