-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI.md: Mention branch protection #2744
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have changed the branch protection configuration to require the Github Actions to succeed, and no longer block on hydra. This PR merely updates our documentation to reflect this. This means we can (and should) ask the IDX team (if it still has that name) to disable hydra for the Motoko repo.
This PR does not affect the produced WebAssembly code. |
osa1
reviewed
Aug 23, 2021
Co-authored-by: Ömer Sinan Ağacan <[email protected]>
crusso
approved these changes
Aug 24, 2021
nomeata
added a commit
that referenced
this pull request
Aug 24, 2021
follow up to #2744: Mergify should consider PRs mergable when the Github actions succeed.
nomeata
added a commit
that referenced
this pull request
Aug 25, 2021
* Ci/Mergify: Wait for github actions, not hydra follow up to #2744: Mergify should consider PRs mergable when the Github actions succeed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have changed the branch protection configuration to require the Github
Actions to succeed, and no longer block on hydra. This PR merely updates
our documentation to reflect this.
This means we can (and should) ask the IDX team (if it still has that
name) to disable hydra for the Motoko repo.