Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trusted types support #32

Closed
wants to merge 3 commits into from
Closed

Conversation

rictic
Copy link

@rictic rictic commented Sep 3, 2019

Makes the Karma jasmine html reporter compatible with an enforced Trusted Types policy.

This should only be necessary for a limited time, as the next version of the proposed specification will not require any special code for URLS (except javascript: URLS).

More info about the proposed Trusted Types standard at https://github.com/WICG/trusted-types

saschanaz and others added 3 commits April 25, 2019 06:10
Makes the Karma jasmine html reporter compatible with an enforced Trusted Types policy.

This should only be necessary for a limited time, as the next version of the proposed specification will not require any special code for URLS (except javascript: URLS).

More info about the proposed Trusted Types standard at https://github.com/WICG/trusted-types
@rictic
Copy link
Author

rictic commented Sep 3, 2019

Related: karma-runner/karma#3360

@dfederm
Copy link
Owner

dfederm commented Sep 4, 2019

See: https://github.com/dfederm/karma-jasmine-html-reporter/blob/master/README.md#develop

Basically, make the change to Jasmine and then I'll copy it into this package

@rictic
Copy link
Author

rictic commented Sep 5, 2019

Sent over jasmine/jasmine#1750

@engelsdamien
Copy link

What is the status of this change ?

@rictic
Copy link
Author

rictic commented Jun 5, 2020

On revisiting, I don't think this is necessary anymore, as the shipping version of TrustedTypes doesn't have or need the createURL function.

@rictic rictic closed this Jun 5, 2020
@rictic rictic deleted the trustedtypes branch September 14, 2020 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants