Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always override specFilter if query exists #25

Merged
merged 1 commit into from
Apr 25, 2019

Conversation

saschanaz
Copy link
Contributor

Retries #24

The previous PR had two problems:

  1. Incorrect to check config.specFilter as it's always undefined because config is our own configuration object rather than jasmine global one.
  2. Incorrect to check existence of specFilter as even the jasmine global configuration always have specFilter which always returns true.

I think adding a query means the user wants to override the existing filter, so maybe better to do this way.

@dfederm dfederm merged commit 453f6b4 into dfederm:master Apr 25, 2019
@saschanaz saschanaz deleted the patch-1 branch April 25, 2019 13:11
@dfederm
Copy link
Owner

dfederm commented Apr 25, 2019

Published 1.4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants