Ensure correct dependency code-generation ordering #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfed
force-pushed
the
dfed--dependency-sort
branch
from
030a10e to
32ebe59
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
==========================================
+ Coverage 99.36% 99.40% +0.03%
==========================================
Files 40 42 +2
Lines 8888 9147 +259
==========================================
+ Hits 8832 9093 +261
+ Misses 56 54 -2
|
dfed
force-pushed
the
dfed--dependency-sort
branch
from
a9f94a7 to
830ceb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our attempt to use
.sorted(...)to sort dependencies in #26 was ill-fated, as this method (reasonably!) stops sorting when neighbors are sorted rather then when all members are sorted relative to one another.The general concept of ordering dependencies based on dependency order was correct however. In this PR, we utilize insertion sort on a linked list to create the proper sort order.