Short-circuit for better performance

dfed · Jan 20, 2024 · a9f94a7 · a9f94a7
1 parent 32ebe59
commit a9f94a7
Showing 1 changed file with 18 additions and 9 deletions.
diff --git a/Sources/SafeDICore/Generators/ScopeGenerator.swift b/Sources/SafeDICore/Generators/ScopeGenerator.swift
@@ -246,18 +246,27 @@ actor ScopeGenerator {
 
     private func generateProperties(leadingMemberWhitespace: String) async throws -> [String] {
         guard var orderedPropertiesToGenerate = List(propertiesToGenerate) else { return [] }
+        let propertiesToGenerate = Set(propertiesToGenerate.compactMap(\.property))
         for propertyToGenerateNode in orderedPropertiesToGenerate {
+            let hasDependenciesGeneratedByCurrentScope = !propertyToGenerateNode
+                .value
+                .requiredReceivedProperties
+                .isDisjoint(with: propertiesToGenerate)
+            guard hasDependenciesGeneratedByCurrentScope else {
+                // This property does not have received dependencies generated by this scope,
+                // Therefore its ordering is irrelevant.
+                continue
+            }
             var lastDependency: List<ScopeGenerator>?
             for nextPropertyToGenerate in propertyToGenerateNode.dropFirst() {
-                guard let nextProperty = nextPropertyToGenerate.value.property else {
-                    continue
-                }
-                let propertyToGenerateDependsOnNextProperty = propertyToGenerateNode
-                    .value
-                    .requiredReceivedProperties
-                    .contains(nextProperty)
-
-                if propertyToGenerateDependsOnNextProperty {
+                if
+                    let nextProperty = nextPropertyToGenerate.value.property,
+                    // The property to generate depends on the next property!
+                    propertyToGenerateNode
+                        .value
+                        .requiredReceivedProperties
+                        .contains(nextProperty)
+                {
                     lastDependency = nextPropertyToGenerate
                 }
             }