Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linter to check no "Apply suggestions" commits #43

Draft
wants to merge 2 commits into
base: devel
Choose a base branch
from
Draft

Add linter to check no "Apply suggestions" commits #43

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40a1b38
Add linter to check no "Apply suggestions" commits
dfarrell07 Jun 28, 2021
d3da7c1
Apply suggestions from code review
dfarrell07 Jun 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/linting.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,24 @@ on:
pull_request:

jobs:
apply-suggestions-commits:
name: 'No "Apply suggestions from code review" Commits'
runs-on: ubuntu-latest
steps:
- name: Get PR commits
id: 'get-pr-commits'
uses: tim-actions/[email protected]
with:
token: ${{ secrets.GITHUB_TOKEN }}

- name: 'Verify no "Apply suggestions from code review" commits foo'
uses: tim-actions/[email protected]
with:
commits: ${{ steps.get-pr-commits.outputs.commits }}
pattern: '^(?!.*(apply suggestions from code review))'
flags: 'i'
error: 'Commits addressing code review feedback should be squashed into the commits under review foo'

code-gen:
name: Submariner K8s API Code Generation
runs-on: ubuntu-latest
Expand Down