Add linter to check no "Apply suggestions" commits #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a linting job to verify that no commit message in a PR contains the case insensitive string "Apply suggestions from code review". Commits with exactly this title are generated by GitHub automatically when proposed changes from code review are accepted from the GitHub UI. A number of such commits have made it into various Submariner/* repos. Commits addressing code review feedback should typically be squashed into the commits under review, or made into well-commented discrete commits. Signed-off-by: Daniel Farrell <[email protected]>
dfarrell07
commented
Jun 28, 2021
dfarrell07
commented
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a linting job to verify that no commit message in a PR contains the
case insensitive string "Apply suggestions from code review". Commits
with exactly this title are generated by GitHub automatically when
proposed changes from code review are accepted from the GitHub UI. A
number of such commits have made it into various Submariner/* repos.
Commits addressing code review feedback should typically be squashed
into the commits under review, or made into well-commented discrete
commits.
Signed-off-by: Daniel Farrell [email protected]