New invitation endpoint #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeatwork
force-pushed
the
new-invitation-endpoint
branch
from
05c0aee
to
edc5677
Compare
|
Discussed a simpler approach with @bobbyrullo
That means you can get rid of handlePOST and a bunch of the new test cases |
joeatwork
force-pushed
the
new-invitation-endpoint
branch
from
edc5677
to
1586a2c
Compare
| @@ -355,9 +361,35 @@ func TestSendResetPasswordEmailHandler(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| type resetPasswordTestCase struct { | |||
There was a problem hiding this comment.
Why define this outside of testResetPasswordHandler?
There was a problem hiding this comment.
Made obsolete in a162744
|
LGTM (with the assumption that you've run through all the tests of course :) ) |
An invitation allows users to both verify their email address and set a new password.
joeatwork
force-pushed
the
new-invitation-endpoint
branch
from
93df33f
to
0c854a2
Compare
bcwaldon
added a commit
to bcwaldon/dex
that referenced
this pull request
Dec 10, 2015
Drive authctl new-client with API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative to #157 - allow newly invited users to simultaneously verify their email addresses and reset their passwords.