email,api: simplest invitation link that could possibly work #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generate a really big url that wraps a password change link and an email validation link together.
|
This method generates a 2190-character URL in my test environment, which is asking a lot of browsers, load-balancers, and servers. There are a number of other possible approaches to this, but none I could think of with such a small diff. |
|
Withdrawing this approach for now in favor of something a bit more deliberate. |
Merged
bcwaldon
added a commit
to bcwaldon/dex
that referenced
this pull request
Dec 10, 2015
Miscellaneous testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate a really big url that wraps a password change link as the redirect URL inside of an email validation link (with yet another url wrapped inside of the password change link).