Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDAP connector: implement connection pooling #309

Closed
ericchiang opened this issue Feb 12, 2016 · 4 comments
Closed

LDAP connector: implement connection pooling #309

ericchiang opened this issue Feb 12, 2016 · 4 comments

Comments

@ericchiang
Copy link
Contributor

ericchiang commented Feb 12, 2016

The LDAP connector implemented in #178 creates a new LDAP session for every request, closing and discarding the connection after login.

Add connection reuse to the existing logic. After attempting to login, connections should be:

  • "reset" by binding anonymously
  • kept alive by occasionally pinging the LDAP server (or discarded if this fails)
  • reused on future login attempts by other dex end-users
@philips
Copy link

philips commented May 4, 2016

@ericchiang @fnordahl can one of you flesh the description out further?

@fnordahl
Copy link
Contributor

fnordahl commented May 9, 2016

@philips I do not have access to edit the description of this issue, but I have fleshed out the description for the PR. Cc @ericchiang

@ericchiang
Copy link
Contributor Author

👍 updated here

@fnordahl
Copy link
Contributor

thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants