Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LDAP: bring back connection pooling #1353

Closed
srenatus opened this issue Nov 21, 2018 · 2 comments
Closed

LDAP: bring back connection pooling #1353

srenatus opened this issue Nov 21, 2018 · 2 comments
Labels
area/connector kind/enhancement

Comments

@srenatus
Copy link
Contributor

Looking at #309 and the current code for the LDAP connector, that pooling behaviour wasn't carried over to dex v2. I would think i is a reasonable feature though, isn't it?
@ericchiang
Copy link
Contributor

The code was really complicated and I felt that it didn't outweigh the benefits. If we have a use case that needs it, I'd be fine adding it back in.

@srenatus
Copy link
Contributor Author

Well, I can't tell, really. I've come across one issue where this could have helped (new LDAP connections randomly failing); but it's not the obvious only solution to that.

Good to know that it wasn't forgotten but excluded for a reason 👍 I'll close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/connector kind/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@srenatus @ericchiang