Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1054 automated security warnings #1083

Merged
merged 10 commits into from
Mar 28, 2023
Merged

#1054 automated security warnings #1083

merged 10 commits into from
Mar 28, 2023

Conversation

CREITZ25
Copy link
Member

#1054 automated security warnings

@github-actions github-actions bot added bash related to bash shell or scripts commandlet related to commandlets (scripts/command/*) documentation related to documentation (AsciiDoc) scripts related to shell scripts (bash and CMD) labels Mar 27, 2023
@CREITZ25 CREITZ25 marked this pull request as ready for review March 27, 2023 14:56
@hohwille hohwille mentioned this pull request Mar 27, 2023
Closed
hohwille
hohwille requested changes Mar 27, 2023
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CREITZ25 very nice. Thanks for your PR that now seems fully functional 👍
I left some last comments for improvement. Please have a look.

scripts/src/main/resources/scripts/functions Outdated Show resolved Hide resolved
scripts/src/main/resources/scripts/functions Outdated Show resolved Hide resolved
scripts/src/main/resources/scripts/functions Outdated Show resolved Hide resolved
scripts/src/main/resources/scripts/functions Outdated Show resolved Hide resolved
@hohwille
Copy link
Member

hohwille commented Mar 27, 2023 •
edited
Loading

For the record: indeed git CLI does not offer a way to just print out the version:

$ git -v
git version 2.39.1.windows.1

You really need some ugly bash pipe scripting to get the the real version 2.39.1[.windows.1].
Too bad - a CLI should always give an option to get the plain version.

@CREITZ25 CREITZ25 requested a review from hohwille March 28, 2023 07:06
CREITZ25
CREITZ25 commented Mar 28, 2023
View reviewed changes
Copy link
Member Author

@CREITZ25 CREITZ25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes implemented

CREITZ25
CREITZ25 commented Mar 28, 2023
View reviewed changes
Copy link
Member Author

@CREITZ25 CREITZ25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

CREITZ25
CREITZ25 commented Mar 28, 2023
View reviewed changes
Copy link
Member Author

@CREITZ25 CREITZ25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

CREITZ25
CREITZ25 commented Mar 28, 2023
View reviewed changes
Copy link
Member Author

@CREITZ25 CREITZ25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

hohwille
hohwille approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CREITZ25 excellent. Thanks for rework 👍
Ready for merge.

@hohwille hohwille added this to the release:2023.04.001 milestone Mar 28, 2023
@hohwille hohwille linked an issue Mar 28, 2023 that may be closed by this pull request
automated security warnings #1054
Closed
@hohwille hohwille merged commit eed28c7 into devonfw:master Mar 28, 2023
@CREITZ25 CREITZ25 deleted the feature/new_software_security_checks branch April 17, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hohwille hohwille hohwille approved these changes

Assignees
No one assigned
Labels
bash related to bash shell or scripts commandlet related to commandlets (scripts/command/*) documentation related to documentation (AsciiDoc) scripts related to shell scripts (bash and CMD)
Projects
None yet
Milestone
release:2023.04.001
Development

Successfully merging this pull request may close these issues.

automated security warnings
2 participants
@CREITZ25 @hohwille