Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automated security warnings #1054

Closed
hohwille opened this issue Feb 3, 2023 · 2 comments · Fixed by #1083
Closed

automated security warnings #1054

hohwille opened this issue Feb 3, 2023 · 2 comments · Fixed by #1083
Assignees
Labels
enhancement New feature or request security related to IT-Security (e.g. vulnerability) software software-package with 3rd party products update related to updating software or the entire devonfw-ide

Comments

@hohwille
Copy link
Member

hohwille commented Feb 3, 2023

Already devonfw-ide does a great job to automated tool installations and meanwhile supports automatic updates to recent versions.
However, IT security gets more and more important. As recent vulnerabilities like CVE-2022-23521 and CVE-2022-41903 show, it would be great if devonfw-ide could automatically warn users if he using outdated and vulnerable software. In case of the specified CVEs it would be git that is about the only tool we do not install and manage. However, during setup we could check the version and raise a fat and red warning if the version is vulnerable. Also projects can and for stability also want to pin the versions of tools to get a reliable and reproduce environment for their team. So to spin this further, it would be great if in the context of #941 we could introduce some kind of configuration file that marks versions that are vulnerable. So we could add the tool and edition for git as git/git/security with something like:

>2.39.0

So when we setup a tool (or for git in case we setup the ide itself) we can check the installed version and test if that version is marked as vulnerable. In that case we would render a fat and red warning to the end-user notifying him to take action:

******** ATTENTION ********
You are using the tool git in version 2.38.0 that has vulnerabilities. Please update the tool to state safe and secure.
For further details and recent information have a look at the following webpage:
https://github.com/devonfw/ide/blob/master/documentation/vulnerabilities.asciidoc

Obviously we would also create this asciidoc documentation page and explain how to update git and how to update tools maintained by devonfw-ide and how to proceed depending on your team role (developer should inform ide admin or provide PR for settings while settings admin should directly push the change and inform the team to call devon ide update).

To explain an advanced use-case:
Maybe a tool maintains several major versions and vulnerabilities only apply to 1.x versions up to 1.11.0 and to 2.x versions up to 2.0.23 we can write this to the security file:

1.0>1.11.0
2.0>2.0.23

This would mean that the versions 1.0-1.11.0 and 2.0-2.0.23 are considered vulnerable.
If we instead write this:

>1.11.0
2.0>2.0.23

This would mean that the versions 0-1.11.0 and 2.0-2.0.23 are considered vulnerable - so also 0.x versions are included.

@hohwille hohwille added enhancement New feature or request software software-package with 3rd party products update related to updating software or the entire devonfw-ide security related to IT-Security (e.g. vulnerability) labels Feb 3, 2023
@CREITZ25 CREITZ25 linked a pull request Mar 19, 2023 that will close this issue
CREITZ25 added a commit to CREITZ25/ide that referenced this issue Mar 27, 2023
CREITZ25 added a commit to CREITZ25/ide that referenced this issue Mar 27, 2023
CREITZ25 added a commit to CREITZ25/ide that referenced this issue Mar 27, 2023
CREITZ25 added a commit to CREITZ25/ide that referenced this issue Mar 27, 2023
CREITZ25 added a commit to CREITZ25/ide that referenced this issue Mar 27, 2023
CREITZ25 added a commit to CREITZ25/ide that referenced this issue Mar 28, 2023
CREITZ25 added a commit to CREITZ25/ide that referenced this issue Mar 28, 2023
CREITZ25 added a commit to CREITZ25/ide that referenced this issue Mar 28, 2023
CREITZ25 added a commit to CREITZ25/ide that referenced this issue Mar 28, 2023
@hohwille hohwille linked a pull request Mar 28, 2023 that will close this issue
@hohwille hohwille added this to the release:2023.04.001 milestone Mar 28, 2023
@hohwille
Copy link
Member Author

Feature is properly implemented.
I reopen this issue as a reminder because when the new ide-urls repo is populated, I want to add the security config for git.

@hohwille
Copy link
Member Author

I created issue #1106 for the remaining todos so we can close this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request security related to IT-Security (e.g. vulnerability) software software-package with 3rd party products update related to updating software or the entire devonfw-ide
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants