Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#550: Fix download url generated from plugin id #615

Merged
merged 5 commits into from
Sep 16, 2024
Merged

#550: Fix download url generated from plugin id #615

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
03e81b3
Fix download url generated from plugin id
slskiba Sep 12, 2024
843bb7e
Merge branch 'main' into bug/550-space-in-pluginid
hohwille Sep 12, 2024
f845fa6
Merge branch 'main' into bug/550-space-in-pluginid
hohwille Sep 13, 2024
59e78a5
Merge branch 'main' into bug/550-space-in-pluginid
jan-vcapgemini Sep 16, 2024
f3a275d
Merge branch 'main' into bug/550-space-in-pluginid
hohwille Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cli/src/main/java/com/devonfw/tools/ide/tool/ide/IdeaBasedIdeToolCommandlet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
import java.io.IOException;
import java.net.HttpURLConnection;
import java.net.URL;
import java.net.URLEncoder;
import java.nio.charset.StandardCharsets;
import java.nio.file.Files;
import java.nio.file.Path;
import java.util.Set;
Expand Down Expand Up @@ -68,7 +70,7 @@ public void installPlugin(PluginDescriptor plugin) {
*/
private String getDownloadUrl(PluginDescriptor plugin) {
String downloadUrl = plugin.getUrl();
String pluginId = plugin.getId();
String pluginId = URLEncoder.encode(plugin.getId(), StandardCharsets.UTF_8).replaceAll("\\+", "%20");

String buildVersion = readBuildVersion();

Expand Down
Loading