#550: Fix download url generated from plugin id #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10888821307Details
💛 - Coveralls |
hohwille
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
@slskiba thanks for this PR and finding a proper solution. I do not know why + is not supported as that seems a common HTTP standard but for sure you did this on purpose.
Using URLEncoder from JDK is a good choice for the fix. 👍
hohwille
added
plugins
hohwille
added
the
reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #550.
Requires merging of #609 to be fully function for zip compressed plugins.