Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#254: part 1: removed duplication of export PATH environment variable in log #255

Merged
merged 1 commit into from
Mar 19, 2024
Merged

#254: part 1: removed duplication of export PATH environment variable in log #255

merged 1 commit into from
Mar 19, 2024

Conversation

VinceHeu
Copy link
Contributor

Closes #254

@CLAassistant
Copy link

CLAassistant commented Mar 19, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@VinceHeu VinceHeu assigned VinceHeu and ndemirca and unassigned VinceHeu Mar 19, 2024
@VinceHeu VinceHeu requested a review from ndemirca March 19, 2024 11:00
hohwille
hohwille approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VinceHeu sometimes things can also be (IDE)easy ;)
Thanks for the urgent and quick fix 👍

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8341825395

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.009%) to 58.478%
Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/commandlet/EnvironmentCommandlet.java 1 92.31%
Totals Coverage Status
Change from base Build 8331157362: -0.009%
Covered Lines: 4062
Relevant Lines: 6694
💛 - Coveralls

@hohwille hohwille added bugfix environment EnvironmentCommandlet, env variables, path, etc. labels Mar 19, 2024
@hohwille hohwille self-assigned this Mar 19, 2024
@hohwille hohwille merged commit 970e1fc into devonfw:main Mar 19, 2024
4 checks passed
@hohwille hohwille changed the title #254-1: removed duplication of export PATH environment variable in log #254: part 1: removed duplication of export PATH environment variable in log Mar 19, 2024
@hohwille hohwille added this to the release:2024.03.001 milestone Mar 19, 2024
@hohwille hohwille mentioned this pull request Mar 19, 2024
Closed
@hohwille hohwille added the story-review marks PRs that will be presented in the sprint-review label May 3, 2024
@ndemirca ndemirca added reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. and removed story-review marks PRs that will be presented in the sprint-review labels May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hohwille hohwille hohwille approved these changes

@ndemirca ndemirca Awaiting requested review from ndemirca

Assignees

@hohwille hohwille

@ndemirca ndemirca

Labels
bugfix environment EnvironmentCommandlet, env variables, path, etc. reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.03.001
Development

Successfully merging this pull request may close these issues.

ide wrapper bash script failing:
5 participants
@VinceHeu @CLAassistant @coveralls @hohwille @ndemirca