ide wrapper bash script failing: #254

hohwille · 2024-03-18T17:26:46Z

Expected behavior

As a IDEasy user, I want to set my environment variables using ide command so that I can work as simple as with devon CLI.

Actual behavior

$ ide
/d/projects/IDEasy/test/bin/ide: eval: line 22: syntax error near unexpected token `('

Steps to reproduce (bug) / Use Case of feature request (enhancement)

run ide wrapper script

Related/Dependent Issues

Comments/Hints:

According to my analysis the error seems to come from path entries with Program Files (x86).
My assumption is that we need to double quote the variable values at least for bash.

Affected version:

OS: Windows
latest SNAPSHOT of IDEasy.

The text was updated successfully, but these errors were encountered:

hohwille · 2024-03-18T17:31:58Z

There is another bug in the ide wrapper script.

This looks good:

$ ideasy.exe env
export PATH=D:\projects\IDEasy\software\jmc;D:\projects\IDEasy\software\node;D:\projects\IDEasy\software\java\bin;D:\projects\IDEasy\software\mvn\bin;D:\projects\IDEasy\software\az\bin;D:\projects\IDEasy\software\intellij\bin;D:\projects\IDEasy\software\aws;D:\projects\IDEasy\software\eclipse;C:\Users\hohwille\bin;C:\Program Files\Git\usr\local\bin;C:\Program Files\Git\usr\bin;C:\Program Files\Git\usr\bin;C:\Program Files\Git\opt\bin;D:\oracle-xe\product\18.0.0\dbhomeXE\bin;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0;C:\WINDOWS\System32\OpenSSH;C:\Program Files (x86)\GnuPG\bin;C:\Program Files\SlikSvn\bin;C:\Program Files\TortoiseSVN\bin;C:\Program Files\Git\cmd;C:\Program Files\Rancher Desktop\resources\resources\win32\bin;C:\Program Files\Rancher Desktop\resources\resources\linux\bin;C:\Users\hohwille\scripts;C:\Program Files\Git\usr\bin\vendor_perl;C:\Program Files\Git\usr\bin\core_perl
MVN_VERSION=3.9.5
INTELLIJ_VERSION=2023.3.2
ECLIPSE_VERSION=2023-09
export AWS_SHARED_CREDENTIALS_FILE=D:\projects\IDEasy\conf\aws\credentials
IDE_HOME=D:/projects/IDEasy
DOTNET_VERSION=6*
NODE_VERSION=v18*
export AWS_CONFIG_FILE=D:\projects\IDEasy\conf\aws\config
export AZURE_CONFIG_DIR=D:\projects\IDEasy\conf\.azure
PYTHON_VERSION=3.11*
WORKSPACE=main
WORKSPACE_PATH=D:/projects/IDEasy/workspaces/main
JAVA_VERSION=blablabla
HOME=C:/Users/hohwille
export PATH=D:\projects\IDEasy\software\jmc;D:\projects\IDEasy\software\node;D:\projects\IDEasy\software\java\bin;D:\projects\IDEasy\software\mvn\bin;D:\projects\IDEasy\software\az\bin;D:\projects\IDEasy\software\intellij\bin;D:\projects\IDEasy\software\aws;D:\projects\IDEasy\software\eclipse;C:\Users\hohwille\bin;C:\Program Files\Git\usr\local\bin;C:\Program Files\Git\usr\bin;C:\Program Files\Git\usr\bin;C:\Program Files\Git\opt\bin;D:\oracle-xe\product\18.0.0\dbhomeXE\bin;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0;C:\WINDOWS\System32\OpenSSH;C:\Program Files (x86)\GnuPG\bin;C:\Program Files\SlikSvn\bin;C:\Program Files\TortoiseSVN\bin;C:\Program Files\Git\cmd;C:\Program Files\Rancher Desktop\resources\resources\win32\bin;C:\Program Files\Rancher Desktop\resources\resources\linux\bin;C:\Users\hohwille\scripts;C:\Program Files\Git\usr\bin\vendor_perl;C:\Program Files\Git\usr\bin\core_perl

But this does not:

$ echo $(ideasy.exe env)
export PATH=D:\projects\IDEasy\software\jmc;D:\projects\IDEasy\software\node;D:\projects\IDEasy\software\java\bin;D:\projects\IDEasy\software\mvn\bin;D:\projects\IDEasy\software\az\bin;D:\projects\IDEasy\software\intellij\bin;D:\projects\IDEasy\software\aws;D:\projects\IDEasy\software\eclipse;C:\Users\hohwille\bin;C:\Program Files\Git\usr\local\bin;C:\Program Files\Git\usr\bin;C:\Program Files\Git\usr\bin;C:\Program Files\Git\opt\bin;D:\oracle-xe\product\18.0.0\dbhomeXE\bin;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0;C:\WINDOWS\System32\OpenSSH;C:\Program Files (x86)\GnuPG\bin;C:\Program Files\SlikSvn\bin;C:\Program Files\TortoiseSVN\bin;C:\Program Files\Git\cmd;C:\Program Files\Rancher Desktop\resources\resources\win32\bin;C:\Program Files\Rancher Desktop\resources\resources\linux\bin;C:\Users\hohwille\scripts;C:\Program Files\Git\usr\bin\vendor_perl;C:\Program Files\Git\usr\bin\core_perl MVN_VERSION=3.9.5 INTELLIJ_VERSION=2023.3.2 ECLIPSE_VERSION=2023-09 export AWS_SHARED_CREDENTIALS_FILE=D:\projects\IDEasy\conf\aws\credentials IDE_HOME=D:/projects/IDEasy DOTNET_VERSION=6* NODE_VERSION=v18* export AWS_CONFIG_FILE=D:\projects\IDEasy\conf\aws\config export AZURE_CONFIG_DIR=D:\projects\IDEasy\conf\.azure PYTHON_VERSION=3.11* WORKSPACE=main WORKSPACE_PATH=D:/projects/IDEasy/workspaces/main JAVA_VERSION=blablabla HOME=C:/Users/hohwille export PATH=D:\projects\IDEasy\software\jmc;D:\projects\IDEasy\software\node;D:\projects\IDEasy\software\java\bin;D:\projects\IDEasy\software\mvn\bin;D:\projects\IDEasy\software\az\bin;D:\projects\IDEasy\software\intellij\bin;D:\projects\IDEasy\software\aws;D:\projects\IDEasy\software\eclipse;C:\Users\hohwille\bin;C:\Program Files\Git\usr\local\bin;C:\Program Files\Git\usr\bin;C:\Program Files\Git\usr\bin;C:\Program Files\Git\opt\bin;D:\oracle-xe\product\18.0.0\dbhomeXE\bin;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0;C:\WINDOWS\System32\OpenSSH;C:\Program Files (x86)\GnuPG\bin;C:\Program Files\SlikSvn\bin;C:\Program Files\TortoiseSVN\bin;C:\Program Files\Git\cmd;C:\Program Files\Rancher Desktop\resources\resources\win32\bin;C:\Program Files\Rancher Desktop\resources\resources\linux\bin;C:\Users\hohwille\scripts;C:\Program Files\Git\usr\bin\vendor_perl;C:\Program Files\Git\usr\bin\core_perl

So it seems we are loosing the newlines of the output if we send it into a variable.
This will not work. Piping it to eval can also not work as this will set the environment variables of a sub-process that then immediately exists and so it has no effect.

hohwille · 2024-03-19T11:07:18Z

Was auto-closed by PR #255 but not all problems solved so reopening.

hohwille · 2024-03-19T11:09:38Z

@aBega2000 got a different error than me. Something like this

/d/projects/IDEasy/test/bin/ide: eval: line 22: C:\projects\IDEasy\software\java\bin: is a directory

hohwille · 2024-03-19T11:15:20Z

For the newlines it is as simple as this:
https://stackoverflow.com/questions/22101778/how-to-preserve-line-breaks-when-storing-command-output-to-a-variable

So:

$ echo $(ideasy env --bash)
export PATH=/d/projects/IDEasy/software/jmc;D:/projects/IDEasy/software/node;D:/projects/IDEasy/software/java/bin;D:/projects/IDEasy/software/mvn/bin;D:/projects/IDEasy/software/az/bin;D:/projects/IDEasy/software/intellij/bin;D:/projects/IDEasy/software/sonar/bin;D:/projects/IDEasy/software/aws;D:/projects/IDEasy/software/eclipse;C:/Users/hohwille/bin;C:/Program Files/Git/usr/local/bin;C:/Program Files/Git/usr/bin;C:/Program Files/Git/usr/bin;C:/Program Files/Git/opt/bin;D:/oracle-xe/product/18.0.0/dbhomeXE/bin;C:/WINDOWS/system32;C:/WINDOWS;C:/WINDOWS/System32/Wbem;C:/WINDOWS/System32/WindowsPowerShell/v1.0;C:/WINDOWS/System32/OpenSSH;C:/Program Files (x86)/GnuPG/bin;C:/Program Files/SlikSvn/bin;C:/Program Files/TortoiseSVN/bin;C:/Program Files/Git/cmd;C:/Program Files/Rancher Desktop/resources/resources/win32/bin;C:/Program Files/Rancher Desktop/resources/resources/linux/bin;C:/Users/hohwille/scripts;C:/Program Files/Git/usr/bin/vendor_perl;C:/Program Files/Git/usr/bin/core_perl MVN_VERSION=3.9.5 INTELLIJ_VERSION=2023.3.2 ECLIPSE_VERSION=2023-09 export AWS_SHARED_CREDENTIALS_FILE=/d/projects/IDEasy/conf/aws/credentials IDE_HOME=D:/projects/IDEasy DOTNET_VERSION=6* NODE_VERSION=v18* export AWS_CONFIG_FILE=/d/projects/IDEasy/conf/aws/config export AZURE_CONFIG_DIR=/d/projects/IDEasy/conf/.azure PYTHON_VERSION=3.11* WORKSPACE=main WORKSPACE_PATH=D:/projects/IDEasy/workspaces/main JAVA_VERSION=blablabla HOME=C:/Users/hohwille

But:

$ echo "$(ideasy env --bash)"
export PATH=/d/projects/IDEasy/software/jmc;D:/projects/IDEasy/software/node;D:/projects/IDEasy/software/java/bin;D:/projects/IDEasy/software/mvn/bin;D:/projects/IDEasy/software/az/bin;D:/projects/IDEasy/software/intellij/bin;D:/projects/IDEasy/software/sonar/bin;D:/projects/IDEasy/software/aws;D:/projects/IDEasy/software/eclipse;C:/Users/hohwille/bin;C:/Program Files/Git/usr/local/bin;C:/Program Files/Git/usr/bin;C:/Program Files/Git/usr/bin;C:/Program Files/Git/opt/bin;D:/oracle-xe/product/18.0.0/dbhomeXE/bin;C:/WINDOWS/system32;C:/WINDOWS;C:/WINDOWS/System32/Wbem;C:/WINDOWS/System32/WindowsPowerShell/v1.0;C:/WINDOWS/System32/OpenSSH;C:/Program Files (x86)/GnuPG/bin;C:/Program Files/SlikSvn/bin;C:/Program Files/TortoiseSVN/bin;C:/Program Files/Git/cmd;C:/Program Files/Rancher Desktop/resources/resources/win32/bin;C:/Program Files/Rancher Desktop/resources/resources/linux/bin;C:/Users/hohwille/scripts;C:/Program Files/Git/usr/bin/vendor_perl;C:/Program Files/Git/usr/bin/core_perl
MVN_VERSION=3.9.5
INTELLIJ_VERSION=2023.3.2
ECLIPSE_VERSION=2023-09
export AWS_SHARED_CREDENTIALS_FILE=/d/projects/IDEasy/conf/aws/credentials
IDE_HOME=D:/projects/IDEasy
DOTNET_VERSION=6*
NODE_VERSION=v18*
export AWS_CONFIG_FILE=/d/projects/IDEasy/conf/aws/config
export AZURE_CONFIG_DIR=/d/projects/IDEasy/conf/.azure
PYTHON_VERSION=3.11*
WORKSPACE=main
WORKSPACE_PATH=D:/projects/IDEasy/workspaces/main
JAVA_VERSION=blablabla
HOME=C:/Users/hohwille

So for this nothing needs to be done as @aBega2000 already quoted the variable correctly here:

IDEasy/cli/src/main/package/bin/ide

Line 18 in 970e1fc

eval "$ide_env"

mvomiero · 2024-03-19T17:20:46Z

If I understood correctly, when running ide env, the current problem is that we get export PATH=/c/Program Files/Git/usr/bin... instead of export PATH="/c/Program Files/Git/usr/bin... (the " is missinig).

A way to solve that could be this, in EnvironmentCommandlet ?

  public void run() {

    Collection<VariableLine> variables = this.context.getVariables().collectVariables();
    for (VariableLine line : variables) {
      if (this.context.getSystemInfo().isWindows()) {
        line = normalizeWindowsValue(line);
+        if (line.getName().equals("PATH")) {
+         String lineValue = '"' + line.getValue() + '"';
+         line = line.withValue(lineValue);
        }
      }
      this.context.info(line.toString());
    }
  }

it solves the problem when running ide env, but I actually don't know if it is the right place or way to change it for our release 🌷

VinceHeu · 2024-03-20T09:35:46Z

2 Questions:
Should we add the quotation marks:
-only for windows or for every os?
-only for path or for every variable?

hohwille · 2024-03-21T10:37:07Z

The quotes new appear and the ide wrapper script is not failing with an error anymore what is great.
However, it is still not working as the PATH contains invalid entries:

$ ide env --bash
export PATH="/d/projects/IDEasy/software/jmc;D:/projects/IDEasy/software/node;D:/projects/IDEasy/software/java/bin;D:/projects/IDEasy/software/mvn/bin;D:/projects/IDEasy/software/az/bin;D:/projects/IDEasy/software/intellij/bin;D:/projects/IDEasy/software/sonar/bin;D:/projects/IDEasy/software/aws;D:/projects/IDEasy/software/eclipse;C:/Users/hohwille/bin;C:/Program Files/Git/usr/local/bin;C:/Program Files/Git/usr/bin;C:/Program Files/Git/usr/bin;C:/Program Files/Git/opt/bin;D:/oracle-xe/product/18.0.0/dbhomeXE/bin;C:/WINDOWS/system32;C:/WINDOWS;C:/WINDOWS/System32/Wbem;C:/WINDOWS/System32/WindowsPowerShell/v1.0;C:/WINDOWS/System32/OpenSSH;C:/Program Files (x86)/GnuPG/bin;C:/Program Files/SlikSvn/bin;C:/Program Files/TortoiseSVN/bin;C:/Program Files/Git/cmd;C:/Program Files/Rancher Desktop/resources/resources/win32/bin;C:/Program Files/Rancher Desktop/resources/resources/linux/bin;C:/Users/hohwille/scripts;C:/Program Files/Git/usr/bin/vendor_perl;C:/Program Files/Git/usr/bin/core_perl"

There are various C:/Program Files entries. When we call this with --bash then all paths need to be printed in bash syntax.
This currently has very bad effects:

$ ls ../../software/
bash: ls: command not found

hohwille added bug Something isn't working windows specific for Microsoft Windows OS bash labels Mar 18, 2024

hohwille added this to IDEasy board Mar 18, 2024

github-project-automation bot moved this to 🆕 New in IDEasy board Mar 18, 2024

VinceHeu added a commit to VinceHeu/IDEasy that referenced this issue Mar 19, 2024

devonfw#254-1: fixed duplication info

5412ab6

VinceHeu mentioned this issue Mar 19, 2024

#254: part 1: removed duplication of export PATH environment variable in log #255

Merged

hohwille closed this as completed in #255 Mar 19, 2024

hohwille pushed a commit that referenced this issue Mar 19, 2024

#254: fixed duplicated PATH variable (#255)

970e1fc

github-project-automation bot moved this from 🆕 New to ✅ Done in IDEasy board Mar 19, 2024

hohwille reopened this Mar 19, 2024

github-project-automation bot moved this from ✅ Done to 📋 Backlog in IDEasy board Mar 19, 2024

VinceHeu added a commit to VinceHeu/IDEasy that referenced this issue Mar 20, 2024

devonfw#254-2: added quotation mark

6f812b0

VinceHeu added a commit to VinceHeu/IDEasy that referenced this issue Mar 20, 2024

devonfw#254-2: added quotation mark and fixed test

bddb38b

VinceHeu mentioned this issue Mar 20, 2024

#254: Part 2: add missing quotation marks #257

Merged

VinceHeu moved this from 📋 Backlog to 🏗 In progress in IDEasy board Mar 20, 2024

tobka777 assigned VinceHeu Mar 21, 2024

hohwille closed this as completed in #257 Mar 21, 2024

hohwille pushed a commit that referenced this issue Mar 21, 2024

#254: Part 2: add missing quotation marks (#257)

5e283b3

github-project-automation bot moved this from 🏗 In progress to ✅ Done in IDEasy board Mar 21, 2024

hohwille reopened this Mar 21, 2024

github-project-automation bot moved this from ✅ Done to 📋 Backlog in IDEasy board Mar 21, 2024

hohwille added a commit to hohwille/IDEasy that referenced this issue Mar 21, 2024

devonfw#254: fix to normalize path for git-bash

79cd967

hohwille mentioned this issue Mar 21, 2024

#254: fix bash path #259

Merged

hohwille closed this as completed in #259 Mar 21, 2024

hohwille added a commit that referenced this issue Mar 21, 2024

#254: fix bash path (#259)

c29606a

github-project-automation bot moved this from 📋 Backlog to ✅ Done in IDEasy board Mar 21, 2024

hohwille added this to the release:2024.03.001 milestone Sep 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ide wrapper bash script failing: #254

ide wrapper bash script failing: #254

hohwille commented Mar 18, 2024

hohwille commented Mar 18, 2024

hohwille commented Mar 19, 2024

hohwille commented Mar 19, 2024

hohwille commented Mar 19, 2024

mvomiero commented Mar 19, 2024

VinceHeu commented Mar 20, 2024

hohwille commented Mar 21, 2024