Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some new icons (Bash, Firebase, Flask, Google-Cloud, Kubernetes, Objective-C, Pandas, Rocksdb, SQLAlchemy, SQL-Server, uWSGI) #170

Closed
wants to merge 3 commits into from

Conversation

ReallyLiri
Copy link

Added icons for the following:

  • Bash
  • Firebase
  • Flask
  • Google-Cloud
  • Kubernetes
  • Objective-C
  • Pandas
  • Rocksdb
  • SQLAlchemy
  • SQL-Server
  • uWSGI

@amacado amacado added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jun 8, 2020
@amacado amacado changed the title Added some new icons Added some new icons (Bash, Firebase, Flask, Google-Cloud, Kubernetes, Objective-C, Pandas, Rocksdb, SQLAlchemy, SQL-Server, uWSGI) Jun 8, 2020
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Please take a look at our updated contribution guidelines and pay special attention to:

  • Create a separated pull request for each icon (no matter how many variations)
  • Modify devicon.json to include the icon (or variations)
  • Modify devicon-colors.css to include the colored version of the icon

@Thomas-Boi
Copy link
Member

Hello there,
Recently, we just introduced an automation pipeline to Devicon which will help us create the icons. Before we can merge your changes in, there are a few things that we need to do first:

  1. Merge the current devicon/develop branch into your PR branch. This contains the build script needed for us to build your icons.
  2. Read the CONTRIBUTING.md for things to do before merging and review our icon standards.
  3. Push your changes and/or branches. We will review them once this is done and merge your PR if everything goes well.

Thank you for contributing to this repo. We are sorry that we haven't accept any PR for awhile. Now that we have a build pipeline, we can merge PRs more quickly than before.

We hope to see your icons in the Devicon repo soon :)

Cheers,
Devicon Team

1 similar comment
@Thomas-Boi
Copy link
Member

Hello there,
Recently, we just introduced an automation pipeline to Devicon which will help us create the icons. Before we can merge your changes in, there are a few things that we need to do first:

  1. Merge the current devicon/develop branch into your PR branch. This contains the build script needed for us to build your icons.
  2. Read the CONTRIBUTING.md for things to do before merging and review our icon standards.
  3. Push your changes and/or branches. We will review them once this is done and merge your PR if everything goes well.

Thank you for contributing to this repo. We are sorry that we haven't accept any PR for awhile. Now that we have a build pipeline, we can merge PRs more quickly than before.

We hope to see your icons in the Devicon repo soon :)

Cheers,
Devicon Team

@jonalxh
Copy link

jonalxh commented Dec 4, 2020

Hi, This icons haven't been merged yet?

@ReallyLiri
Copy link
Author

@jonalxh unfortunately I don't have time to conform to the pull request requirements beyond making this one. If anyone wants to pick it up, you're most welcome to.

@Thomas-Boi
Copy link
Member

Hello all,

The icons in this PR has been added by various new PRs. Props to @ReallyLiri for creating the SVGs and @EnisMulic for refactoring it and submitting the new PR.

I'll now close this PR since everything has been added.

@Thomas-Boi Thomas-Boi closed this Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
5 participants