Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new icon: googlecloud (original, original-wordmark, plain, plain-wordmark) #428

Merged
merged 11 commits into from
Jan 5, 2021
Merged

new icon: googlecloud (original, original-wordmark, plain, plain-wordmark) #428

merged 11 commits into from
Jan 5, 2021

Conversation

EnisMulic
Copy link
Contributor

Taken from #170

@amacado amacado added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jan 3, 2021
@amacado
Copy link
Member

amacado commented Jan 3, 2021

Hi @EnisMulic! Nice to see you have decided to pick up some old pull requests and fix them. We are currently investigating some issues regarding our bot:peek command (#414) so it can take some time until the review. Sorry for that.

@EnisMulic
Copy link
Contributor Author

That's fine, I still have a few icons from this PR to fix up.

@amacado amacado added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Jan 4, 2021
amacado
amacado requested changes Jan 4, 2021
View reviewed changes
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EnisMulic Thanks for your contribution!

In the font versions (plain and workmark) of the svg you can see "cutting lines" which does not look like they are intended.

image

Here are the bot:peek results as font preview:

new_icons
screenshot_0
screenshot_1

icons/googlecloud/googlecloud-plain.svg Outdated Show resolved Hide resolved
icons/googlecloud/googlecloud-plain-wordmark.svg Outdated Show resolved Hide resolved
icons/googlecloud/googlecloud-original-wordmark.svg Outdated Show resolved Hide resolved
icons/googlecloud/googlecloud-original.svg Outdated Show resolved Hide resolved
@Thomas-Boi Thomas-Boi added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jan 5, 2021
@Thomas-Boi
Copy link
Member

Hello there,

Here are the icon build results:
new_icons

screenshot_0

screenshot_1

While the cut off lines have been fixed, I couldn't help but notice that the plain-wordmark icon looks like it's shifted upwards and it's different from before. I think it looks better before so is this change intentional?

Besides that, everything looks great. If the change above is intentional, I can accept your PR. However, I think it would better centered.

@Thomas-Boi Thomas-Boi mentioned this pull request Jan 5, 2021
Closed
@EnisMulic
Copy link
Contributor Author

When I took a closer look the previous icons looked terrible when you would zoom in closer as the parts that it was made out of obviously looked detached and not aligned, so I replaces everything entirely. As for the shift, It's caused by setting the viewBox to 0 0 128 128 so I left it like that as I didn't know how to fix that and the guidelines say that should be the specified settings.

amacado
amacado requested changes Jan 5, 2021
View reviewed changes
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EnisMulic thanks for updating. The 0 0 128 128 requirement for the icons was developed to have all icons in the same view box which helps when making global changes.
The off-centering does not look good and should be fixed before adding this icon to to project.

amacado
amacado requested changes Jan 5, 2021
View reviewed changes
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a slight left/right margin difference (for original and plain), but much better!

image

@amacado
Copy link
Member

amacado commented Jan 5, 2021

@EnisMulic could you please request a review once you're done? So we don't have to check every commit.. :)

@EnisMulic EnisMulic requested a review from amacado January 5, 2021 19:12
@amacado amacado added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jan 5, 2021
amacado
amacado approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📦 and will be in the next release. Thanks @EnisMulic for the work! :) well done.

@amacado amacado merged commit 5e4c2d6 into devicons:develop Jan 5, 2021
@EnisMulic EnisMulic deleted the ReallyLiri/feature/icon/googlecloud branch January 5, 2021 21:23
@amacado amacado mentioned this pull request Jan 19, 2021
Merged
amacado added a commit that referenced this pull request Jan 20, 2021
@amacado @tylensthilaire
@EnisMulic @Thomas-Boi @Th1nkK1D @moghya @eldadfux @github-actions
Release 2.9.0 (#485)
9c6bfdb 
* Create eleventy-original.svg

* Create eleventy-plain.svg

* Update devicon.json

* Update eleventy-plain.svg

* Update eleventy-original.svg

* new icon: sqlalchemy (plain, original, original-workmark)

* Add font aliase for sqlalchemy

* new icon: microsoftsqlserver (plain, plain-wordmark) (#427)

* new icon sqlserver (plain, plain-woodmark)

* Update icons/sqlserver/sqlserver-plain-wordmark.svg

Co-authored-by: Clemens Bastian <[email protected]>

* Update icons/sqlserver/sqlserver-plain.svg

Co-authored-by: Clemens Bastian <[email protected]>

* Update devicon.json

Co-authored-by: Clemens Bastian <[email protected]>

* Update devicon.json

Co-authored-by: Clemens Bastian <[email protected]>

* Rename sqlserver icons to microsoftsqlserver

Co-authored-by: Clemens Bastian <[email protected]>

* new icon: kubernetes (plain, plain-wordmark) (#424)

* new icon: kubernetes (plain, plain-wordmark)

* Update icons/kubernetes/kubernetes-plain.svg

Co-authored-by: Clemens Bastian <[email protected]>

* Update icons/kubernetes/kubernetes-plain-wordmark.svg

Co-authored-by: Clemens Bastian <[email protected]>

Co-authored-by: Clemens Bastian <[email protected]>

* new icon: rocksdb (plain) (#423)

* new icon: rocksdb (plain)

* Update icons/rocksdb/rocksdb-plain.svg

Co-authored-by: Clemens Bastian <[email protected]>

Co-authored-by: Clemens Bastian <[email protected]>

* new icon: googlecloud (original, original-wordmark, plain, plain-wordmark) (#428)

* new icon: googlecloud (plain, plain-wordmark, original, original-wordmark)

* Update icons/googlecloud/googlecloud-plain.svg

Co-authored-by: Clemens Bastian <[email protected]>

* Update icons/googlecloud/googlecloud-original-wordmark.svg

Co-authored-by: Clemens Bastian <[email protected]>

* Update icons/googlecloud/googlecloud-original.svg

Co-authored-by: Clemens Bastian <[email protected]>

* Fix google cloud icons

* Fix googlecloud original

* Remove fill redefinition from google cloud original

* Fix googlecloud alignment (Test)

* Fix googlecloud alignment (test)

* Fix googlecloud alignment (test)

Co-authored-by: Clemens Bastian <[email protected]>

* new icon: objectivec (plain) (#425)

* new icon: objectivec (plain)

* Update icons/objectivec/objectivec-plain.svg

Co-authored-by: Clemens Bastian <[email protected]>

Co-authored-by: Clemens Bastian <[email protected]>

* new icon uwsgi (original, plain)

* Cleanup uwsgi icons

* Update devicon.json

Co-authored-by: Thomas Bui <[email protected]>

* Add adobe XD line icon

* Add xd-plain and eps file

* Clean up xd svg file

* Update devicon.json

* new icon: firebase (plain, plain-wordmark) (#461)

* add icon Firebase (plain, plain-wordmark), Closes #204

* new icon: firebase (plain, plain-wordmark)

* update icons

* Add plain-wordmark to firebase fonts

* new icon: flask (original, original-wordmark) (#463)

* Cleanup flask icon

* Improve flask icons

* Update icons/flask/flask-original-wordmark.svg

Co-authored-by: Clemens Bastian <[email protected]>

Co-authored-by: moghya <[email protected]>
Co-authored-by: Clemens Bastian <[email protected]>

* Update devicon.json

* Fixed an error with devicon.json

* Added check script for the icons and fix icons with fill or viewBox issues (#460)

* Added script to check svg fill and viewBox

* Fix cucumber-plain-wordmark

* Fix various fill and viewBox issues in svgs

* Added check for height and width attr

* Added check_svgs workflow

* Fix an issue where the error is not log properly

* Added on push for testing

* Updated trigger so it now runs whenever PR is update

* Added sleep to script to make logs nicer

* Added script that create env var

* Updated the github_env to accomodate ubuntu

* Change format of log and allow filehandler to return Path

* Updated logging messages

* Updated refs for the checkout action

* Make logging nicer

* Updated fix messaging so it's more clear

* fix icons: icons/cucumber/cucumber-plain-wordmark.svg, icons/intellij/intellij-plain-wordmark.svg, icons/jenkins/jenkins-plain.svg, icons/twitter/twitter-original.svg, icons/yunohost/yunohost-plain.svg

* Fix the ref issue of the checkout action and sqlalchemy  (#472)

* Remove head_ref from checkout action

* Fixed the svg errs in sqlalchemy

* Create a monthly script that checks all svgs

* Python now print traceback

* Updated file names in check_svgs_on_pr

* Remove deprecated and unused svg syntax

Co-authored-by: Clemens Bastian <[email protected]>

* Remove deprecated and unused svg syntax

Co-authored-by: Clemens Bastian <[email protected]>

* Update svg fill, remove unused class

* Change comment action to a new action

* Add guideline about squash merging

As the result of discussion #470 update guidelines with squash merging

* Redo the workflow archs so we can comment on pr

* Moved check_svgs_monthly to draft

* Added working workflow file

* Changed to file read action

* new icon: appwrite (plain, original, wordmark) (#371)

* Added Appwrite icon

* Fixed wrong JSON input

* Fixed JSON style

* Fixed indent

* Update devicon.json

Co-authored-by: Clemens Bastian <[email protected]>

* Update devicon.json

Co-authored-by: Clemens Bastian <[email protected]>

* Update devicon.json

Co-authored-by: Clemens Bastian <[email protected]>

Co-authored-by: Clemens Bastian <[email protected]>

* bot:build new icons, icomoon.json and devicon.css (#486)

* fix bash-plain (#451) (#453)

Co-authored-by: Enis Mulić <[email protected]>

* Built new icons, icomoon.json and devicon.css

Co-authored-by: Clemens Bastian <[email protected]>
Co-authored-by: Enis Mulić <[email protected]>
Co-authored-by: amacado <[email protected]>

* Removed 'default fall back icon' from build_icons.yml

Co-authored-by: Tylen St Hilaire <[email protected]>
Co-authored-by: Enis Mulić <[email protected]>
Co-authored-by: Thomas Bui <[email protected]>
Co-authored-by: Withee Poositasai <[email protected]>
Co-authored-by: moghya <[email protected]>
Co-authored-by: Thomas Bui <[email protected]>
Co-authored-by: Eldad A. Fux <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: amacado <[email protected]>
@tupaschoal tupaschoal mentioned this pull request Jun 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amacado amacado amacado approved these changes

Assignees

@EnisMulic EnisMulic

Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EnisMulic @amacado @Thomas-Boi