Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update icon: webstorm (original, plain, plain-wordmark) #1317

Merged
merged 3 commits into from
Aug 19, 2022
Merged

update icon: webstorm (original, plain, plain-wordmark) #1317

merged 3 commits into from
Aug 19, 2022

Conversation

kilianpaquier
Copy link
Contributor

@kilianpaquier kilianpaquier commented Jul 26, 2022 •
edited
Loading

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format update icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here

This PR contributes to #1125

Link to prove your SVG is correct and up-to-date.

https://www.jetbrains.com/fr-fr/webstorm/

@Snailedlt Snailedlt added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jul 28, 2022
@Panquesito7 Panquesito7 added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label Aug 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Panquesito7
Panquesito7 previously approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! 🚀

__
sema-logo  Summary: 🏆 This code is awesome  |  Tags: Efficient

Snailedlt
Snailedlt reviewed Aug 3, 2022
View reviewed changes
icons/webstorm/webstorm-plain-wordmark.svg
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 128 128">
<path d="M55.75 50.965v14.73h3.063v-1.422a4.158 4.158 0 0 0 3.37 1.614c2.559 0 4.919-1.976 4.919-5.586v-.04c0-3.61-2.398-5.585-4.918-5.585-1.593 0-2.626.746-3.371 1.754v-5.465H55.75zm16.984.406c-2.882 0-4.941 1.691-4.941 4.254v.04c0 2.804 1.824 3.593 4.664 4.315 2.359.61 2.844 1.008 2.844 1.793v.043c0 .825-.765 1.329-2.035 1.329-1.605 0-2.945-.667-4.215-1.715l-1.836 2.199a8.98 8.98 0 0 0 6 2.258c3.047 0 5.18-1.575 5.18-4.375v-.04c0-2.46-1.613-3.488-4.473-4.234-2.442-.625-3.047-.93-3.047-1.855v-.043c0-.684.63-1.227 1.816-1.227 1.192 0 2.422.524 3.672 1.39l1.61-2.339a8.172 8.172 0 0 0-5.239-1.793zm-39.343.16-3.172 9.598-2.926-9.559h-3.316l4.82 14.227h2.7l3.183-9.246 3.187 9.242h2.703l4.817-14.223H42.14l-2.922 9.559-3.164-9.598H33.39zm-28.059.016V65.77h14.223V51.547H5.332zm74.402.57v2.774h-1.289V57.5h1.29v5.121h-.003c0 2.497 1.272 3.246 3.147 3.246a4.501 4.501 0 0 0 2.422-.629v-2.457a3.15 3.15 0 0 1-1.514.383c-.688 0-.986-.336-.986-1.047v-4.633h2.53V54.88H82.8v-2.762h-3.067zm-64.027 1.13a3.108 3.108 0 0 1 1.984.683l-.609.886a2.52 2.52 0 0 0-1.39-.535c-.455 0-.688.207-.688.473v.016c0 .35.234.472 1.152.71 1.086.282 1.7.672 1.7 1.606v.016c0 1.062-.812 1.656-1.97 1.656a3.392 3.392 0 0 1-2.265-.856v-.007l.695-.833a2.446 2.446 0 0 0 1.598.649c.473 0 .77-.188.77-.504v-.016c0-.296-.184-.448-1.079-.68-1.078-.272-1.773-.574-1.773-1.632v-.016c0-.968.781-1.617 1.875-1.617zm-9.102.073h1.243l.793 3.11.91-3.11h.902l.906 3.11.797-3.11h1.242l-1.523 5.336h-1.012L10 55.57l-.871 3.086h-1L6.605 53.32zm42.766 1.356c-3.144 0-5.34 2.547-5.34 5.625v.043c0 3.304 2.4 5.582 5.633 5.582 1.957 0 3.406-.768 4.414-2.018l-1.754-1.554c-.836.79-1.581 1.11-2.61 1.11-1.37 0-2.339-.722-2.64-2.112h7.52c.02-.286.039-.571.039-.809 0-3.063-1.652-5.867-5.262-5.867zm42.238 0c-3.367 0-5.867 2.519-5.867 5.625v.043c0 3.102 2.461 5.582 5.824 5.582 3.368 0 5.868-2.52 5.868-5.625v-.04c0-3.105-2.46-5.585-5.825-5.585zm12.926.004c-1.61.04-2.531.976-3.117 2.375v-2.176h-3.063v10.805h3.063v-3.989c0-2.582 1.25-3.812 3.285-3.812h.164v-3.2a4.589 4.589 0 0 0-.332-.003zm7.668.004c-1.55 0-2.473.824-3.183 1.73V54.88h-3.063v10.805h3.066v-6.028c0-1.454.707-2.199 1.856-2.199 1.148 0 1.793.746 1.793 2.2v6.027h3.066v-6.028c0-1.454.703-2.199 1.852-2.199 1.152 0 1.797.746 1.797 2.2v6.027h3.07v-7.032c0-2.6-1.372-3.968-3.652-3.968-1.477 0-2.605.602-3.555 1.71-.567-1.09-1.625-1.71-3.047-1.71zm-62.832 2.453c1.29 0 2.097.929 2.277 2.297h-4.617c.242-1.391 1.051-2.297 2.34-2.297zm12.016.14c1.433 0 2.64 1.193 2.64 2.985v.039h.008c0 1.816-1.22 2.988-2.64 2.988-1.426 0-2.61-1.184-2.61-2.988v-.04c0-1.792 1.172-2.984 2.602-2.984zm30.18.037c1.695 0 2.843 1.397 2.843 2.987v.043c0 1.59-1.047 2.943-2.8 2.94-1.696 0-2.848-1.39-2.848-2.983v-.04c0-1.593 1.05-2.947 2.804-2.947zM7.104 63.086h5.336v.887H7.105v-.887zm17.575 7.988v5.367h.566v-.73a1.712 1.712 0 0 0 1.457.809c.918 0 1.813-.735 1.813-1.977v-.016c0-1.258-.903-1.968-1.813-1.968a1.717 1.717 0 0 0-1.457.843v-2.328h-.566zm34.597.11v.636h.649v-.636h-.649zm-9.898.11a1.869 1.869 0 0 0-.184.003h-2.191v5.137h2.285c1.125 0 1.867-.523 1.867-1.403v-.015c0-.707-.491-1.059-1.101-1.243a1.246 1.246 0 0 0 .816-1.187v-.012a1.154 1.154 0 0 0-.328-.824 1.898 1.898 0 0 0-1.164-.455zm-11.348.003v3.457c0 .816-.426 1.234-1.008 1.234-.543 0-.867-.257-1.183-.734l-.418.36a1.757 1.757 0 0 0 1.59.898 1.567 1.567 0 0 0 1.133-.426c.332-.367.503-.856.472-1.352v-3.437h-.586zm6.274.193v1.15h-.528v.5h.528v2.294c0 .769.46 1.072 1.074 1.06.238 0 .473-.054.684-.164v-.473a1.228 1.228 0 0 1-.551.133.564.564 0 0 1-.64-.633v-2.216h1.202v-.5H44.87v-1.15h-.566zm3.273.326h1.563c.738 0 1.14.332 1.14.836l.004.016c0 .605-.488.922-1.183.922h-1.524v-1.774zm-6.094.743c-1.054 0-1.824.882-1.824 1.976v.016a1.894 1.894 0 0 0 1.899 1.972c.602.02 1.18-.242 1.562-.71l-.351-.313a1.56 1.56 0 0 1-1.2.535 1.325 1.325 0 0 1-1.336-1.285h3.02a1.44 1.44 0 0 0 0-.184c0-1.109-.649-2.007-1.77-2.007zm21.489 0a1.432 1.432 0 0 0-1.301.742v-.66h-.57v3.804h.57V74.27a1.116 1.116 0 0 1 1.137-1.184c.67 0 1.05.438 1.05 1.148v2.22h.567v-2.372c0-.906-.534-1.523-1.453-1.523zm3.75.004c-.75 0-1.293.433-1.293 1.085v.016c0 .7.66.906 1.257 1.074.5.141.946.285.946.668v.016c0 .367-.328.601-.785.601a2.202 2.202 0 0 1-1.317-.472l-.285.402a2.61 2.61 0 0 0 1.574.567c.754 0 1.352-.43 1.352-1.141v-.031c0-.684-.633-.91-1.223-1.09-.504-.153-.976-.293-.976-.653v-.015c0-.312.285-.55.738-.55a2.174 2.174 0 0 1 1.121.366l.258-.426a2.57 2.57 0 0 0-1.367-.418zm-10.035.007c-.056-.001-.112 0-.168.004-.481 0-.953.11-1.383.32l.172.473a2.609 2.609 0 0 1 1.152-.277c.71 0 1.133.351 1.133 1.035v.133a4.054 4.054 0 0 0-1.168-.164c-.966 0-1.625.43-1.625 1.23v.012c0 .782.71 1.184 1.426 1.172a1.666 1.666 0 0 0 1.375-.653v.575h.535v-2.325a1.487 1.487 0 0 0-.39-1.109 1.663 1.663 0 0 0-1.06-.426zm-2.34.004a1.613 1.613 0 0 0-.942.281 1.61 1.61 0 0 0-.61.778v-.992h-.566v3.8h.567v-1.515c0-1.145.676-1.742 1.508-1.742h.043v-.61zm-25.45.059 1.727 3.793c-.231.53-.441.71-.781.71a1.155 1.155 0 0 1-.594-.14l-.191.45a1.709 1.709 0 0 0 .808.187c.574 0 .942-.28 1.266-1.07l1.594-3.922h-.602l-1.223 3.16-1.382-3.168h-.622zm30.418.008v3.793h.563V72.64h-.563zm-17.847.394c.758 0 1.152.606 1.21 1.293h-2.445c.075-.738.57-1.293 1.235-1.293zm-14.871.031c.722 0 1.34.575 1.34 1.47v.015c0 .918-.606 1.46-1.34 1.46a1.42 1.42 0 0 1-1.375-1.468v-.016a1.423 1.423 0 0 1 1.375-1.46zm20.98 1.036h1.625c.9 0 1.367.328 1.363.882V75c0 .57-.484.918-1.261.918h-1.727v-1.816zm8.906.402a4.006 4.006 0 0 1 1.118.164v.375c0 .602-.576 1.03-1.282 1.02-.509 0-.949-.282-.949-.754v-.02c0-.477.403-.785 1.113-.785z"/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing fill?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to the #1291 thread

@Snailedlt Snailedlt added the awaiting triage Awaiting triage from a maintainer label Aug 6, 2022
Snailedlt
Snailedlt requested changes Aug 6, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as request changes until #1291 is solved

@Snailedlt Snailedlt added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed awaiting triage Awaiting triage from a maintainer bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Aug 18, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

Snailedlt
Snailedlt approved these changes Aug 19, 2022
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️

@Snailedlt Snailedlt merged commit 656d95c into devicons:develop Aug 19, 2022
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@kilianpaquier @Snailedlt
update icon: webstorm (original, plain, plain-wordmark) (devicons#1317)
3827b3c 
* update icon: webstorm (original, plain, plain-wordmark) - contributes to devicons#1125

* webstorm | added original-wordmark
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@kilianpaquier @Snailedlt
update icon: webstorm (original, plain, plain-wordmark) (devicons#1317)
8ce517d 
* update icon: webstorm (original, plain, plain-wordmark) - contributes to devicons#1125

* webstorm | added original-wordmark
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
@kilianpaquier @Snailedlt
update icon: webstorm (original, plain, plain-wordmark) (devicons#1317)
63584ed 
* update icon: webstorm (original, plain, plain-wordmark) - contributes to devicons#1125

* webstorm | added original-wordmark
@kilianpaquier kilianpaquier deleted the webstorm branch October 19, 2022 19:56
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snailedlt Snailedlt Snailedlt approved these changes

@Panquesito7 Panquesito7 Panquesito7 left review comments

Assignees
No one assigned
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kilianpaquier @Snailedlt @Panquesito7