-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update icon: clion (original, plain, plain-wordmark) #1291
Conversation
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<path style="fill:#000;fill-opacity:1;fill-rule:nonzero;stroke:none" d="M3.22 40.805v23.86h23.99v-23.86H3.22zm7.08 2.808a4.71 4.71 0 0 1 3.579 1.395l-1.262 1.453a3.375 3.375 0 0 0-2.32-1.016c-1.531 0-2.633 1.266-2.633 2.813v.023c0 1.547 1.078 2.836 2.633 2.836 1.035 0 1.672-.398 2.398-1.058l1.25 1.285a4.663 4.663 0 0 1-3.73 1.59 4.584 4.584 0 0 1-3.305-1.336 4.542 4.542 0 0 1-1.34-3.29v-.027a4.567 4.567 0 0 1 1.366-3.34 4.64 4.64 0 0 1 3.365-1.328zm4.938.149h2v7.308h3.936v1.664h-5.936v-8.972zM6.211 60.156h8.996v1.489H6.213l-.002-1.489z"/> | ||
<path style="fill:#000;fill-opacity:1;fill-rule:nonzero;stroke:none" d="M34.41 76.785v-.066c0-6.785 5.137-12.328 12.508-12.328 4.527 0 7.234 1.5 9.46 3.683l-3.358 3.848c-1.852-1.672-3.735-2.692-6.133-2.692-4.047 0-6.961 3.34-6.961 7.434v.066c0 4.094 2.844 7.5 6.96 7.5 2.739 0 4.4-1.093 6.305-2.785l3.36 3.375c-2.469 2.625-5.2 4.262-9.836 4.262-7.082-.023-12.305-5.445-12.305-12.297zM58.348 64.79h5.277v19.086h11.973v4.773h-17.25zm19.336-1.023h5.484v4.601h-5.484zm.136 6.613h5.2v18.27h-5.2zm7.375 9.234v-.066c0-5.25 4.246-9.512 9.973-9.512s9.914 4.195 9.914 9.442v.07c0 5.25-4.254 9.512-9.977 9.512-5.718 0-9.91-4.172-9.91-9.446zm14.735 0v-.066c0-2.695-1.953-5.043-4.832-5.043-2.98 0-4.766 2.281-4.766 4.973v.07c0 2.695 1.957 5.047 4.836 5.047 2.988 0 4.77-2.285 4.77-4.98zm7.125-9.234h5.199v2.578c1.2-1.535 2.742-2.934 5.383-2.934 3.941 0 6.238 2.59 6.238 6.786v11.84h-5.2V78.456c0-2.453-1.167-3.715-3.155-3.715-1.985 0-3.254 1.262-3.254 3.715v10.191h-5.2zm-70.832 35.058v1.215h-.953v-9h.953v3.91a2.888 2.888 0 0 1 2.457-1.421c1.535 0 3.058 1.195 3.058 3.308v.024c0 2.082-1.511 3.32-3.058 3.32-1 0-1.926-.516-2.457-1.356zm4.539-1.949v-.027c0-1.504-1.043-2.469-2.258-2.469a2.393 2.393 0 0 0-2.32 2.457v.024c-.02.632.21 1.25.644 1.71a2.42 2.42 0 0 0 1.676.758c1.238 0 2.258-.914 2.258-2.453zm7.062-3.21h1.016l-2.688 6.585c-.547 1.32-1.168 1.801-2.132 1.801a2.93 2.93 0 0 1-1.364-.32l.324-.754c.305.164.653.246 1 .234.575 0 .934-.293 1.317-1.191l-2.914-6.363h1.054l2.329 5.316zm5.567 4.972.703-.605c.539.796 1.082 1.234 2 1.234.98 0 1.695-.707 1.695-2.074v-5.793h.992v5.77a3.093 3.093 0 0 1-.8 2.269c-.516.48-1.2.734-1.907.715a2.981 2.981 0 0 1-2.683-1.516zm7.152-1.762v-.027c0-1.84 1.297-3.32 3.074-3.32 1.895 0 2.988 1.507 2.988 3.37.004.102.004.204 0 .305h-5.097a2.232 2.232 0 0 0 2.258 2.16c.77.009 1.507-.32 2.02-.898l.612.528a3.312 3.312 0 0 1-2.636 1.195 3.212 3.212 0 0 1-2.325-.973 3.152 3.152 0 0 1-.894-2.34zm5.094-.37c-.102-1.161-.77-2.173-2.043-2.173-1.117 0-1.961.922-2.086 2.172zm2.738 1.847v-3.848h-.89v-.84h.89v-1.922h.957v1.922h2.031v.84h-2.031v3.727c0 .773.43 1.058 1.078 1.058.324 0 .64-.074.93-.218v.793a2.42 2.42 0 0 1-1.153.273c-1.03.012-1.812-.492-1.812-1.785zm4.555-6.953h3.695a3.205 3.205 0 0 1 2.27.761c.367.368.566.868.558 1.383v.028a2.08 2.08 0 0 1-1.379 1.988c1.031.308 1.864.898 1.864 2.082v.023c0 1.48-1.254 2.356-3.149 2.356h-3.86zm5.53 2.281c0-.852-.679-1.406-1.92-1.406h-2.642v2.968h2.567c1.176 0 2-.527 2-1.539zm-1.823 2.426h-2.739v3.047h2.899c1.312 0 2.133-.578 2.133-1.54v-.027c.015-.922-.778-1.468-2.293-1.468zm5.11-2.442h.956v1.668a2.719 2.719 0 0 1 1.024-1.304 2.743 2.743 0 0 1 1.59-.473v1.023h-.075c-1.398 0-2.539 1-2.539 2.926v2.535h-.957zm4.335 4.528v-.032c0-1.347 1.117-2.062 2.738-2.062a6.733 6.733 0 0 1 1.973.273v-.203c0-1.148-.707-1.734-1.91-1.734a4.43 4.43 0 0 0-1.945.465l-.29-.797a5.292 5.292 0 0 1 2.332-.527 2.82 2.82 0 0 1 2.07.699c.466.508.704 1.18.657 1.863v3.895h-.914v-.957a2.834 2.834 0 0 1-2.32 1.097c-1.192.008-2.391-.672-2.391-1.98zm4.711-.496v-.614a6.838 6.838 0 0 0-1.883-.273c-1.2 0-1.875.52-1.875 1.32v.031c0 .793.746 1.266 1.598 1.266 1.203-.004 2.16-.715 2.16-1.73zm2.844-6.47h1.09v1.048h-1.09zm.062 2.438h.953v6.364H93.7zm3.016 0h.957v1.114a2.432 2.432 0 0 1 2.195-1.25c1.551 0 2.453 1.039 2.453 2.554v3.977h-.957v-3.723c0-1.191-.64-1.926-1.77-1.926a1.895 1.895 0 0 0-1.398.579c-.367.375-.554.89-.523 1.414v3.644h-.957zm6.988 5.563.48-.68a3.752 3.752 0 0 0 2.22.797c.773 0 1.327-.398 1.327-1.012v-.027c0-.64-.753-.887-1.597-1.121-1.004-.281-2.121-.629-2.121-1.797v-.012c0-1.097.922-1.824 2.183-1.824.82.016 1.617.258 2.305.703l-.434.723a3.652 3.652 0 0 0-1.894-.617c-.762 0-1.238.398-1.238.926v.027c0 .601.796.836 1.644 1.097.992.293 2.063.676 2.063 1.825v.023c0 1.191-1.008 1.91-2.286 1.91a4.415 4.415 0 0 1-2.652-.941zm0 0" transform="translate(1.001 -24)"/> | ||
<svg viewBox="0 0 128 128" xmlns="http://www.w3.org/2000/svg"> | ||
<path d="M76.59 44.016v4.195h4.972v-4.195H76.59zm-27.899.57c-6.683 0-11.343 5.055-11.343 11.242v.059c0 6.25 4.738 11.19 11.156 11.215 4.207 0 6.683-1.497 8.922-3.887l-3.047-3.078c-1.727 1.544-3.234 2.539-5.719 2.539-3.73 0-6.308-3.106-6.308-6.84v-.059c0-3.734 2.64-6.777 6.308-6.777 2.176 0 3.887.93 5.563 2.453l3.047-3.508c-2.02-1.993-4.473-3.36-8.579-3.36zm10.364.363v21.754h15.64v-4.348H63.84V44.95h-4.785zm-50.895.016v21.754h21.754V44.965H8.16zm6.422 2.562a4.25 4.25 0 0 1 3.242 1.27l-1.144 1.328a3.038 3.038 0 0 0-2.102-.93c-1.39 0-2.387 1.153-2.387 2.563v.023c0 1.41.977 2.586 2.387 2.586.938 0 1.516-.363 2.176-.965l1.129 1.168a4.213 4.213 0 0 1-3.38 1.453 4.16 4.16 0 0 1-4.214-4.218v-.024a4.187 4.187 0 0 1 4.293-4.254zm4.477.133h1.812v6.664h3.57v1.516h-5.38l-.002-8.18zm93.757 2.063c-2.39 0-3.794 1.273-4.879 2.675v-2.351h-4.714l.011 16.656h4.715V57.41c0-2.234 1.15-3.387 2.95-3.387 1.804 0 2.863 1.153 2.863 3.387v9.293h4.71V55.91c0-3.824-2.077-6.187-5.656-6.187zm-20.375.011c-5.19 0-9.043 3.883-9.043 8.672v.059c0 4.808 3.8 8.613 8.989 8.613 5.19 0 9.047-3.887 9.047-8.672v-.062c0-4.785-3.797-8.61-8.993-8.61zm-15.726.313v16.656h4.71V50.047h-4.71zm15.668 3.762c2.61 0 4.379 2.14 4.379 4.597v.059h.008c0 2.46-1.614 4.543-4.329 4.543-2.609 0-4.382-2.145-4.382-4.602v-.062c0-2.457 1.618-4.535 4.324-4.535zm-81.512 8.8h8.16v1.36h-8.16v-1.36zm27.26 12.305v8.207h.865v-1.11a2.63 2.63 0 0 0 2.229 1.235c1.402 0 2.771-1.125 2.771-3.027v-.02c0-1.925-1.381-3.015-2.771-3.015a2.615 2.615 0 0 0-2.229 1.296v-3.566h-.865zm52.926.172v.953h.988v-.953h-.988zm-32.504.156v5.281c0 1.246-.65 1.891-1.54 1.891-.832 0-1.329-.398-1.814-1.125l-.635.55h-.002a2.696 2.696 0 0 0 2.434 1.384 2.43 2.43 0 0 0 1.729-.649 2.845 2.845 0 0 0 .724-2.07v-5.262h-.896zm13.726 0-.002 7.86h3.5c1.72 0 2.858-.797 2.858-2.145v-.023c0-1.082-.76-1.618-1.69-1.899a1.89 1.89 0 0 0 1.246-1.816v-.024a1.74 1.74 0 0 0-.502-1.257 2.876 2.876 0 0 0-2.06-.696h-3.35zm-4.13.313v1.754h-.807v.765h.806v3.508h.002c0 1.18.705 1.637 1.64 1.625a2.175 2.175 0 0 0 1.048-.246v-.727a1.818 1.818 0 0 1-.846.2c-.586 0-.974-.258-.974-.965v-3.395h1.84v-.765h-1.84v-1.754h-.87zm5.007.484h2.397c1.125 0 1.742.508 1.742 1.281l.004.024c0 .922-.748 1.402-1.815 1.402h-2.328V76.04zm-9.324 1.145c-1.609 0-2.787 1.351-2.787 3.023v.027a2.918 2.918 0 0 0 .81 2.137 2.905 2.905 0 0 0 2.112.883 2.985 2.985 0 0 0 2.388-1.086l-.556-.484a2.395 2.395 0 0 1-1.828.82 2.025 2.025 0 0 1-2.047-1.969h4.62a3.297 3.297 0 0 0 0-.281c0-1.695-.993-3.07-2.712-3.07zm32.871 0a2.206 2.206 0 0 0-1.99 1.14V77.31h-.863v5.82h.863V79.8a1.706 1.706 0 0 1 .475-1.285 1.714 1.714 0 0 1 1.269-.528c1.023 0 1.606.668 1.606 1.758v3.39h.869v-3.624c0-1.383-.823-2.328-2.229-2.328zm5.742.02c-1.148 0-1.978.663-1.978 1.663v.012c0 1.067 1.01 1.379 1.92 1.637.766.214 1.45.441 1.45 1.023v.027c0 .56-.503.918-1.202.918a3.366 3.366 0 0 1-2.014-.722l-.435.617a3.964 3.964 0 0 0 2.406.855c1.156 0 2.068-.652 2.068-1.738v-.023c0-1.047-.967-1.394-1.865-1.664-.77-.235-1.496-.45-1.496-1v-.024c0-.48.436-.844 1.123-.844a3.296 3.296 0 0 1 1.72.563l.39-.66a3.993 3.993 0 0 0-2.087-.64zm-18.933.003a2.456 2.456 0 0 0-1.44.434c-.426.288-.75.702-.93 1.187v-1.52h-.869v5.813h.87V80.81c0-1.758 1.028-2.668 2.298-2.668h.07v-.934zm3.32.016a4.84 4.84 0 0 0-2.111.484l.26.727a3.997 3.997 0 0 1 1.761-.426c1.094 0 1.737.535 1.737 1.586v.183a6.037 6.037 0 0 0-1.791-.25c-1.472 0-2.485.653-2.485 1.88v.027c0 1.194 1.09 1.812 2.168 1.804a2.557 2.557 0 0 0 2.108-1v.875h.828v-3.55a2.283 2.283 0 0 0-.594-1.7 2.567 2.567 0 0 0-1.881-.64zm-42.254.078 2.645 5.8c-.348.82-.676 1.09-1.196 1.09a1.853 1.853 0 0 1-.91-.214l-.293.683a2.583 2.583 0 0 0 1.239.293c.874 0 1.437-.438 1.937-1.64l2.436-6.004h-.918l-1.873 4.84-2.11-4.848h-.957zm46.535.008v5.8h.866v-5.8h-.866zm-27.3.609c1.156 0 1.761.918 1.851 1.98h-3.74c.113-1.14.878-1.98 1.889-1.98zm-22.75.043c1.101 0 2.046.875 2.046 2.246v.027c0 1.403-.92 2.239-2.047 2.239a2.18 2.18 0 0 1-2.105-2.254v-.02a2.175 2.175 0 0 1 2.105-2.238zm32.093 1.574h2.487v.012c1.375 0 2.089.496 2.078 1.336v.027c0 .875-.747 1.403-1.934 1.403h-2.63v-2.778zm13.615.64a6.014 6.014 0 0 1 1.708.247v.562c0 .926-.868 1.576-1.958 1.579-.774 0-1.455-.434-1.455-1.157v-.027c0-.731.615-1.203 1.705-1.203z"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this also have the default color as fill?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should have original-wordmark with the default color and plain-wordmark with green color? But then the plain version would be against TOS since the square in the middle has to be black. Not sure if that applies to us though
I want some more opinions on this though. @Panquesito7 @BenSouchet @kilian-paquier any thoughts on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @BenSouchet
Thanks for chiming in!
Okey, but what about this from the Jetbrains Brand Assets page though?
The Black Box used in our logos must remain untouched – in terms of both its color and proportions to the text. Make sure that the Black Box always remains black and is never changed (e.g inverted) to another color, even from the official color palette of JetBrains.
Shouldn't we follow it when we can, or at the very least not encourage usage against their guildelines/terms?
This is what I think:
I don't think it's a good idea to fill in the background, nor to use the logo sent above. Mainly because it limits users by choosing the background color for them. Leaving it transparent gives more options. But also because transparent background is one of the requirements when adding icons to devicons as per the SVG Standards. Furthermore I think we should use the "Product Logo" jetbrains provides in their brand guidelines to encourage correct usage of the icons/logos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Snailedlt
I disagree.
original
version should always be the exact original logo of the tool / product, for jetbrains logos the white square is filled with white:
Taken from https://www.jetbrains.com/company/brand/
And the screen I share in my previous comment is from the product homepage of clion.
In the quote you shared Black Box used in our logos must remain untouched
this means with the white part (for the original
version)
Now for plain
version these white part must be transparent otherwise in the devicon font generated it will be a full fill square (since for the font colors are ignored)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, what do we do ? 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I say keep it as it is, unless @Panquesito7 is strongly against that :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kilian-paquier @Snailedlt
I still think that we should add an clion-original-wordmark.svg
version with the filled white areas on the square. Like the one you shared in your previous comment @Snailedlt .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed!
@kilian-paquier Could you add a original-wordmark logo like explained above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amacado agreed that this is a good solution, so I think we can go ahead and merge this once clion-original-wordmark
has been added as specified above.
@kilian-paquier ^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clion-original-wordmark.svg
version with filled white areas on the square should be added
Ok will do |
@kilian-paquier while you're at it. Can you do the same with your other PR's? I noticed some of the others were also missing original-wordmark with white inside the square |
Yep. Also, we merged some JetBrains products already 🙁 |
Yeah, I noticed. Maybe you could make a PR to fix the things we've mentioned in these newer PR's for the already merged icons? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only missing a clion-original-wordmark
version with the official unedited wordmark logo (white parts must be intact), and we're good to go :)
Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! 🚀
* update icon: clion (original, plain) - contributes to devicons#1125 * clion| added original svg * Update devicon.json Co-authored-by: Jørgen Kalsnes Hagen <[email protected]> Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
* update icon: clion (original, plain) - contributes to devicons#1125 * clion| added original svg * Update devicon.json Co-authored-by: Jørgen Kalsnes Hagen <[email protected]> Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
* update icon: clion (original, plain) - contributes to devicons#1125 * clion| added original svg * Update devicon.json Co-authored-by: Jørgen Kalsnes Hagen <[email protected]> Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
Double check these details before you open a PR
develop
branch.This PR contributes to #1125
Link to prove your SVG is correct and up-to-date.
https://www.jetbrains.com/clion/