Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: ballerina (original, plain, line, original-wordmark, plain-wordmark, line-wordmark) #1205

Merged
merged 3 commits into from
Jun 21, 2022

Conversation

zachary-cauchi
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes NONE

Link to prove your SVG is correct and up-to-date.

@amacado amacado added feature:icon Use this label for pull requests when a new icon is ready to be added to the collection bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jun 6, 2022
@github-actions

This comment was marked as outdated.

@Panquesito7 Panquesito7 changed the title add icon: ballerina (original, plain, line, original-wordmark, plain-wordmark, line-wordmark) new icon: ballerina (original, plain, line, original-wordmark, plain-wordmark, line-wordmark) Jun 6, 2022
@Panquesito7 Panquesito7 added bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger labels Jun 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2022

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images Imgur Images Imgur Images Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images Imgur Images Imgur Images Imgur Images

Here are the colored versions:
Imgur Images Imgur Images Imgur Images Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@zachary-cauchi
Copy link
Contributor Author

Hi @Panquesito7. Looks like the pr passed the second check, but skipped the first one. If this is okay, would you kindly review and approve the pr please?

@@ -536,6 +536,33 @@
"color": "#002A41",
"aliases": []
},
{
"name": "ballerina",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please add alternative names (altnames) for the icon? Should be something similar to the following.

        "name": "ballerina",
        "altnames": ["1st", "2nd", "etc."],

__
sema-logo  Summary: 🛠️ This code needs a fix  |  Tags: Not maintainable

@github-actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

SVG Error in 'ballerina-original.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

SVG Error in 'ballerina-original-wordmark.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

SVG Error in 'ballerina-plain.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

SVG Error in 'ballerina-plain-wordmark.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

SVG Error in 'ballerina-line.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

SVG Error in 'ballerina-line-wordmark.svg':
- 'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg.

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🚀

__
sema-logo  Summary: 🏆 This code is awesome  |  Tags: Efficient, Maintainable

@Panquesito7 Panquesito7 merged commit f101763 into devicons:develop Jun 21, 2022
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…wordmark, line-wordmark) (devicons#1205)

* feat: add ballerina icon

* fix: retrigger pr checks

* feat: add ballerina altnames
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…wordmark, line-wordmark) (devicons#1205)

* feat: add ballerina icon

* fix: retrigger pr checks

* feat: add ballerina altnames
Snailedlt pushed a commit to Snailedlt/devicon that referenced this pull request Oct 15, 2022
…wordmark, line-wordmark) (devicons#1205)

* feat: add ballerina icon

* fix: retrigger pr checks

* feat: add ballerina altnames
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants