Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add icon: ballerina (original, plain, line, original-wordmark, plain-wordmark, line-wordmark) #1197

Closed
wants to merge 1 commit into from

Conversation

zachary-cauchi
Copy link
Contributor

@zachary-cauchi zachary-cauchi commented May 27, 2022

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes NONE

Link to prove your SVG is correct and up-to-date.

@zachary-cauchi zachary-cauchi changed the title add icon: Ballerina add icon: Ballerina (original, plain, line, original-wordmark, plain-wordmark, line-wordmark) May 27, 2022
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your contribution! Some suggestions:

  • Please do not auto-format the devicon.json. You introduct a huge changeset which is not required.
  • I'm not sure about the wordmark version. Can you prove that this is the original wordmark? I would assume it's only the font (which includes the icon). But your pr submits the font plus icon

@zachary-cauchi
Copy link
Contributor Author

Hello, and thanks for the welcome. Regarding the points:

  • Sorry about that. Will remove the autoformatting and recommit just my addition.
  • Regarding the wordmark, would you please elaborate? I'm unfamiliar with it and may have misunderstood. The font and icon was just my joining of the two main logos (the original SVG plus the logo on their homepage)

@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label May 28, 2022
@Panquesito7 Panquesito7 added the bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger label May 28, 2022
@github-actions
Copy link
Contributor

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem.

util.find_object_added_in_pr: Couldn't find an icon matching the name in the PR title.
PR title is: 'add icon: Ballerina (original, plain, line, original-wordmark, plain-wordmark, line-wordmark)'

Make sure that:

  • Your svgs are named and added correctly to the /icons folder as seen here.
  • Your icon information has been added to the devicon.json as seen here
  • Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

@zachary-cauchi zachary-cauchi changed the title add icon: Ballerina (original, plain, line, original-wordmark, plain-wordmark, line-wordmark) add icon: ballerina (original, plain, line, original-wordmark, plain-wordmark, line-wordmark) May 29, 2022
@zachary-cauchi
Copy link
Contributor Author

Hi @Panquesito7. I fixed the title so the Peek Icons check should read it fine. Would you rerun it please?

@amacado
Copy link
Member

amacado commented Jun 6, 2022

@zach128 sadly out bot does not parse updated titles. You have to re-create the pr.. :)

@zachary-cauchi
Copy link
Contributor Author

Hi @amacado. I see, no problem. I'll re-create it.

@zachary-cauchi
Copy link
Contributor Author

Re-created the pr here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:peek Use this label to trigger peek-bot. Remove and re-add the label to re-trigger feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants