-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add icon: ballerina (original, plain, line, original-wordmark, plain-wordmark, line-wordmark) #1197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! Thank you for your contribution! Some suggestions:
- Please do not auto-format the
devicon.json
. You introduct a huge changeset which is not required. - I'm not sure about the wordmark version. Can you prove that this is the original wordmark? I would assume it's only the font (which includes the icon). But your pr submits the font plus icon
Hello, and thanks for the welcome. Regarding the points:
|
Hi there, I'm Devicons' Peek Bot and it seems we've ran into a problem.
Make sure that:
I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate. Best of luck, |
Hi @Panquesito7. I fixed the title so the Peek Icons check should read it fine. Would you rerun it please? |
@zach128 sadly out bot does not parse updated titles. You have to re-create the pr.. :) |
Hi @amacado. I see, no problem. I'll re-create it. |
Re-created the pr here |
Double check these details before you open a PR
develop
branch.devicon.json
file as seen hereThis PR closes NONE
Link to prove your SVG is correct and up-to-date.