add more resource requirement in generator #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephanie <[email protected]>
Signed-off-by: Stephanie <[email protected]>
kim-tsao
reviewed
Oct 14, 2021
pkg/devfile/generator/utils.go
Outdated
| if comp.Container != nil { | ||
| if comp.Container.MemoryLimit != "" { | ||
| memoryLimit, err := resource.ParseQuantity(comp.Container.MemoryLimit) | ||
| if err == nil { |
There was a problem hiding this comment.
Should we issue an error message if ParseQuantity fails? The field will not be set in that case
There was a problem hiding this comment.
good point. updated
kim-tsao
reviewed
Oct 14, 2021
pkg/devfile/generator/utils.go
Outdated
| requests[corev1.ResourceMemory] = memoryRequest | ||
| } | ||
| } | ||
| if comp.Container.CpuLimit != "" { |
There was a problem hiding this comment.
This should check for Container.CpuRequest
Signed-off-by: Stephanie <[email protected]>
yangcao77
force-pushed
the
641-resource-limits
branch
from
26d36e8 to
fd79c14
Compare
kim-tsao
approved these changes
Oct 14, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kim-tsao, yangcao77 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stephanie [email protected]
What does this PR do?:
This PR adds additional resource requirements from spec in generator. Also modifies unit test accordingly
Which issue(s) this PR fixes:
Fixes devfile/api#641
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
How to test changes / Special notes to the reviewer: