Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devfile/library doesn't reflect additional resource limits #641

Closed
kadel opened this issue Oct 8, 2021 · 0 comments · Fixed by devfile/library#119
Closed

devfile/library doesn't reflect additional resource limits #641

kadel opened this issue Oct 8, 2021 · 0 comments · Fixed by devfile/library#119
Assignees
Labels
area/library Common devfile library for interacting with devfiles kind/bug Something isn't working

Comments

@kadel
Copy link
Member

kadel commented Oct 8, 2021

/kind bug

Which area this bug is related to?

/area library

What versions of software are you using?

Operating System:

Go Pkg Version:
devfile/library v1.2.0

Bug Summary

Describe the bug:

Additional resource settings were added in redhat-developer/odo#5132

To Reproduce:
define container component with

    memoryLimit: 1Gi
    memoryRequest: 1Gi
    cpuRequest: 1m
    cpuLimit: 1m

Devfile library translates it to container with only

        resources:
          limits:
            memory: 1Gi

memoryRequest, cpuRequest, cpuLimit are not reflected

Expected behavior

to have all fields reflected in kubernetes container spec

    resources:
      requests:
        memory: "1Gi"
        cpu: "1m"
      limits:
        memory: "1Gi"
        cpu: "1m"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/library Common devfile library for interacting with devfiles kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants