Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to devfile 220 #1

Merged
merged 3 commits into from
Nov 10, 2021
Merged

update to devfile 220 #1

merged 3 commits into from
Nov 10, 2021

Conversation

yangcao77
Copy link
Contributor

Signed-off-by: Stephanie [email protected]

Signed-off-by: Stephanie <[email protected]>
@kadel
Copy link

kadel commented Nov 5, 2021

This doesn't look right. To have a proper outerloop definition you need kind: deploy command. That defines what should be executed in outerloop scenario. The way how it is written right now it would mean that all components tools, outerloop-build, outerloop-deploy should be executed on startup and application would be running in both outerloop and innerloop mode.

You should add kind: deploy command as it is in https://github.com/devfile/api/blob/main/samples/devfiles/outerloop-dockerfile-build-inlined-deploy-devfile.yaml#L99-L105

  - id: build-image
    apply:
      component: outerloop-build
  - id: deployk8s
    apply:
      component: outerloop-deploy
  - id: deploy
    composite:
      commands:
        - build-image
        - deployk8s
      group:
        kind: deploy

Signed-off-by: Stephanie <[email protected]>
devfile.yaml Outdated
rootRequired: false
- name: outerloop-deploy
kubernetes:
uri: outerloop-deploy.yaml
- name: tools
container:
image: quay.io/eclipse/che-java11-maven:nightly
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update tools container of those devfiles to use the developer image like quay.io/devfile/universal-developer-image:ubi8-d433ed6 instead of the quay.io/eclipse/che-java11-maven:nightly images that no longer exists ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out the nightly image has been deleted. I've updated to use 7.36.0 instead. The universal developer image is huge (1.4G), and we need more discussion on whether we should switch to use that image in devfile samples. I have created an issue for that discussion, and we can talk more on that in next cabel call: devfile/api#674

I will merge the PR now to unblock the work in odc, which requires the 2.2.0 spec. We can update the samples anytime later if we decided to use another image.

@yangcao77 yangcao77 merged commit 34ef90b into devfile-samples:main Nov 10, 2021
yangcao77 added a commit that referenced this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants