Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devfiles in the OpenShift Dev Console samples are invalid #666

Closed
l0rd opened this issue Nov 3, 2021 · 5 comments
Closed

Devfiles in the OpenShift Dev Console samples are invalid #666

l0rd opened this issue Nov 3, 2021 · 5 comments
Assignees
Labels
area/registry Devfile registry for stacks and infrastructure kind/bug Something isn't working

Comments

@l0rd
Copy link
Contributor

l0rd commented Nov 3, 2021

/kind bug
/area registry

Bug Summary

These 4 OpenShift console samples have a invalid devfile.yaml at their root (1, 2, 3, 4):

image

All have a buildguidance container referencing a nonexistent buildguidanceimage-placeholder:

  - name: buildguidance
    attributes:
      tool: console-import
    container:
      image: buildguidanceimage-placeholder. # <== this image doesn't exist

As a consequence CRW fails to start the workspaces (related issue).

Additional context

openshift/console#8729

@openshift-ci openshift-ci bot added kind/bug Something isn't working area/registry Devfile registry for stacks and infrastructure labels Nov 3, 2021
@l0rd
Copy link
Contributor Author

l0rd commented Nov 3, 2021

This issue should be fixed when those devfiles will be replaced by valid v2.2.0 devfiles. @yangcao77 @elsony please share an example of such a file so that we can test on our hand if those will work with CRW 2.13.

@l0rd
Copy link
Contributor Author

l0rd commented Nov 10, 2021

There are 3 pull requests to update the devfiles to 2.2 but those won't fix the samples currently included in ODC, they fix devfiles that will eventually be included in future versions of ODC:

devfile-samples/devfile-sample-java-springboot-basic#1
devfile-samples/devfile-sample-code-with-quarkus#1
devfile-samples/devfile-sample-python-basic#1

@yangcao77
Copy link
Contributor

@l0rd The change is now in ODC 4.9 and 4.10, to consume devfile 2.2.0 samples from registry. Are we good to close this issue?

@l0rd
Copy link
Contributor Author

l0rd commented Jan 6, 2022

@yangcao77 sure, closing this issue.
Can you please help me to find the developer console PRs that address the problem (change the git repos)?
Do you know what version of OCP 4.9 include the fix? I have deployed 4.9.12 this morning but the sample git repos are the old ones.

@l0rd l0rd closed this as completed Jan 6, 2022
@yangcao77
Copy link
Contributor

yangcao77 commented Jan 6, 2022

@l0rd
4.10: openshift/console#10394
4.9: openshift/console#10620

Just noticed that it's not merged into 4.9 yet. The PR has been approved, but requires console QE team to help add a cherry-pick-approved in order to merge it: https://docs.google.com/document/d/15L4qMJSzt3D8ALe1swmaTTw3ncYvmcDQ6FWyCMHCH5A/edit#heading=h.lsvwx94q6j1x
And it will be shipped after QE has tested, based on this calendar https://app.smartsheet.com/b/publish?EQBCT=970c5ff6c67a4ca7a153e3a6ef993e77
I will track on that PR and let you know once it's merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/registry Devfile registry for stacks and infrastructure kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants