Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumberInput - align StepperButton between design and code #436

Open
2 tasks
thrbnhrtmnn opened this issue Oct 13, 2023 · 0 comments
Open
2 tasks

NumberInput - align StepperButton between design and code #436

thrbnhrtmnn opened this issue Oct 13, 2023 · 0 comments
Labels
🚫 blocked This issue is blocked ⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Oct 13, 2023

Description / User Story

Currently the Number Input uses some IconButton tokens for the StepperButton in code, but in design we have unique StepperButton tokens, as well as the internal stepperButton and stepperCombo components. We need to align design and code. The creation of the stepper components in code is a requirement for this issue and will be done within #462 .

As PO
I need to use the same tokens in the code for the StepperButton as are used in the design
so that token changes are applied to the component as expected.


Requirements


Acceptance Criteria

  • Design & Code have been aligned and the NumberInput uses the StepperButton and StepperComponent in the same way in design and code

Background information

@thrbnhrtmnn thrbnhrtmnn added this to the Release 1.0 milestone Oct 13, 2023
@thrbnhrtmnn thrbnhrtmnn added 🎨 design issue Task is for designers ⌨️ dev issue Task is for developers labels Dec 1, 2023
@thrbnhrtmnn thrbnhrtmnn added ⭕ core team issue This is for the core team and should not be done by contributors and removed 🎨 design issue Task is for designers labels Jan 5, 2024
@thrbnhrtmnn thrbnhrtmnn added the 🚫 blocked This issue is blocked label Jan 9, 2024
@thrbnhrtmnn thrbnhrtmnn removed this from the Release 1.0 milestone Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚫 blocked This issue is blocked ⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers
Projects
None yet
Development

No branches or pull requests

1 participant