Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StepperButton & StepperCombo - build & document internal components #462

Open
1 of 6 tasks
Tracked by #436
thrbnhrtmnn opened this issue Oct 18, 2023 · 0 comments
Open
1 of 6 tasks
Tracked by #436
Labels
🚫 blocked This issue is blocked ⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Oct 18, 2023

Description / User Story

The StepperButton & StepperCombo currently exists in design and their tokens are also part of the NumberInput in code. With this task we want to implement both as internal components.


Requirements


Acceptance Criteria

  • StepperButton is a component in the code
  • StepperCombo is a component in the code
  • A page for the StepperButton exists in Storybook (similar to design template and other components)
  • A page for the StepperCombo exists in Storybook (similar to design template and other components)
  • Props used are similar to design (size-variant, layout, icons, disabled) and have been documented in the Props Excel.

Background information

  • Should it be placed under internal components? > yes
  • Should it also be used in the Slider where we currently use Icon buttons? (may be already its own task) > Create a follow up task for this.
@thrbnhrtmnn thrbnhrtmnn added this to the Release 1.0 milestone Oct 18, 2023
@thrbnhrtmnn thrbnhrtmnn changed the title Stepper - add component page in Storybook Stepper - build & document internal component Oct 30, 2023
@thrbnhrtmnn thrbnhrtmnn changed the title Stepper - build & document internal component StepperButton & StepperCombo - build & document internal components Oct 30, 2023
@thrbnhrtmnn thrbnhrtmnn removed this from the Release 1.0 milestone Oct 30, 2023
@thrbnhrtmnn thrbnhrtmnn added the ⌨️ dev issue Task is for developers label Dec 1, 2023
@thrbnhrtmnn thrbnhrtmnn added the ⭕ core team issue This is for the core team and should not be done by contributors label Jan 5, 2024
@thrbnhrtmnn thrbnhrtmnn added this to the Release 1.0 milestone Jan 9, 2024
@thrbnhrtmnn thrbnhrtmnn added the 🚫 blocked This issue is blocked label Jan 12, 2024
@thrbnhrtmnn thrbnhrtmnn removed this from the Release 1.0 milestone Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚫 blocked This issue is blocked ⭕ core team issue This is for the core team and should not be done by contributors ⌨️ dev issue Task is for developers
Projects
None yet
Development

No branches or pull requests

1 participant