Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NumberInput - fix Stepper Button (design only task) #245

Closed
larserbach opened this issue Jul 13, 2023 · 5 comments
Closed

NumberInput - fix Stepper Button (design only task) #245

larserbach opened this issue Jul 13, 2023 · 5 comments
Assignees
@thrbnhrtmnn
Labels
🎨 design issue Task is for designers 🚨 new::bug Something isn't working
Milestone
Align & Fix First...

Comments

@larserbach
Copy link
Contributor

larserbach commented Jul 13, 2023 •
edited by thrbnhrtmnn
Loading

This task is only relevant for design.

Apply Action.Silent color tokens on the stepper button.

https://www.figma.com/file/C4vgEKz8mKyulJ4gm3Qdql/%F0%9F%AB%A7-THE-B01LER-%5Bv-003-a%5D?type=design&node-id=3391-106330&mode=design&t=bsi01MC1QJYXY66A-11
@larserbach larserbach changed the title Fix Apply Stepper Button Fix Stepper Button Jul 13, 2023
@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Jul 27, 2023 •
edited
Loading

Done on Theming Branch, obsolete Stepper Button Tokens (Colour) still need to be removed now

@thrbnhrtmnn thrbnhrtmnn reopened this Jul 27, 2023
@thrbnhrtmnn thrbnhrtmnn changed the title Fix Stepper Button Fix Stepper Button (design only task) Aug 18, 2023
@angelicahoyss angelicahoyss mentioned this issue Aug 24, 2023
Closed
14 tasks
@thrbnhrtmnn
Copy link
Contributor

We should verify again, if this task also affects dev.

@thrbnhrtmnn thrbnhrtmnn added the 🚨 new::bug Something isn't working label Sep 29, 2023
@thrbnhrtmnn thrbnhrtmnn added this to the Release 1.0 milestone Sep 29, 2023
@thrbnhrtmnn
Copy link
Contributor

Hey @m-nti , can we close this issue? It has the label, but is still in to-do.

@thrbnhrtmnn
Copy link
Contributor

Had a look at this task in todays Weekly Checkup.

We saw that in code we use some tokens (i.e. colour) from icon button for the stepper button inside the number input.

We can close this issue and create a follow up task to further align the components. Either only have icon button tokens or fully have stepper button tokens.

@m-nti
Copy link
Contributor

m-nti commented Oct 12, 2023

@thrbnhrtmnn

thanks for following up on this!

@larserbach larserbach assigned thrbnhrtmnn and unassigned m-nti Oct 12, 2023
@thrbnhrtmnn thrbnhrtmnn mentioned this issue Oct 13, 2023
Open
2 tasks
@thrbnhrtmnn thrbnhrtmnn changed the title Fix Stepper Button (design only task) NumberInput - fix Stepper Button (design only task) Oct 17, 2023
@thrbnhrtmnn thrbnhrtmnn added the 🎨 design issue Task is for designers label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thrbnhrtmnn thrbnhrtmnn

Labels
🎨 design issue Task is for designers 🚨 new::bug Something isn't working
Projects
None yet
Milestone
Align & Fix First 15 Components
Development

No branches or pull requests
3 participants
@larserbach @m-nti @thrbnhrtmnn