Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button Group - design & build component #246

Closed
14 tasks done
larserbach opened this issue Jul 13, 2023 · 3 comments
Closed
14 tasks done

Button Group - design & build component #246

larserbach opened this issue Jul 13, 2023 · 3 comments
Assignees
Labels
🎨 design issue Task is for designers ⌨️ dev issue Task is for developers 🎓 junior issue Good for juniors
Milestone

Comments

@larserbach
Copy link
Contributor

larserbach commented Jul 13, 2023

User Story
As a user, I want to be presented with a set of related options grouped together in a button group, so that I can easily select one option from the group and perform a specific action.

Acceptance Criteria

  • The button group can display minimum of one button and can be filled with any amount of buttons. The overflow is handled with flex container and would break the overflowing buttons in a new row.

  • The button group comes in the following layout variants:

  • Left aligned

  • Right aligned

  • Centrally aligned

  • The button group comes in the following sizing variants:

    • XS
    • SM
    • MD
    • LG
    • XL
  • The sizing should always be applied on the entire button group (all buttons in the button group should have the same size)

  • The button group is always using FlexBox (ParentFill)

  • The button group can be filled with any kind of button and combination of different button variants (Primary, Secondary, Icon button and combinations of these)

Link to Figma: https://www.figma.com/file/C4vgEKz8mKyulJ4gm3Qdql/%F0%9F%AB%A7-%5BBLR%5D-The-B01LER?node-id=3777%3A114816&mode=dev

All components we build should be responsive and work across all modern browsers and devices. Furthermore all components should be tested thoroughly to ensure they are functional and meet all requirements. Components should also be accessible to users with disabilities, following WCAG 2.1 AA guidelines. These requirements however will not be checked 100 % when we review the component tickets during refinement or planning sessions.

@thrbnhrtmnn thrbnhrtmnn changed the title Button Group Button Group - design & build component Jul 17, 2023
@larserbach larserbach removed their assignment Aug 21, 2023
@angelicahoyss angelicahoyss added the 🎓 junior issue Good for juniors label Aug 24, 2023
@angelicahoyss
Copy link
Contributor

angelicahoyss commented Aug 24, 2023

Deleted :)

@JpunktWpunkt
Copy link
Contributor

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Sep 26, 2023

As discussed in todays review and merge session, the ticket can be merged. However we had to create one follow-up task to also have the icon button placeable inside the button group: #387

Additionally we also found a bug in the Text Button, which also affects the Button Group: #384

@thrbnhrtmnn thrbnhrtmnn added 🎨 design issue Task is for designers ⌨️ dev issue Task is for developers labels Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 design issue Task is for designers ⌨️ dev issue Task is for developers 🎓 junior issue Good for juniors
Projects
None yet
Development

No branches or pull requests

7 participants