Calendar multiday (and all day) events fix. #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arashsheyda
approved these changes
Oct 18, 2024
dgmouris
reviewed
Oct 18, 2024
Comment on lines
+38
to
+39
| event.start.dateTime || event.start.date, | ||
| event.end.dateTime || event.end.date, |
There was a problem hiding this comment.
Yep, that looks awesome! Thanks @charrde I'm going to merge a bit later today so that we can observe the deployment together.
MandyMeindersma
approved these changes
Oct 18, 2024
dgmouris
added
the
hacktoberfest-accepted
dgmouris
approved these changes
Oct 18, 2024
|
@charrde we'll merge this which is awesome but a few things here
Thank again! |
|
Merging we're going to fix this wierd date thing later, I would like to have the meetups up so that I can see them and we can fix it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue is this referencing?
This PR fixes #418
Do these code changes work locally and have you tested that they fix the issue yourself?
Does the following command run without warnings or errors?
npm run pr-checksHave you taken a look at our contributing guidelines?
My node version matches the one suggested when running
nvm use?