Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Multiday events on the calendar not showing up on the events page. #418

Closed
dgmouris opened this issue Oct 17, 2024 · 10 comments · Fixed by #419 or #429
Closed

BUG: Multiday events on the calendar not showing up on the events page. #418

dgmouris opened this issue Oct 17, 2024 · 10 comments · Fixed by #419 or #429

Comments

@dgmouris
Copy link
Collaborator

dgmouris commented Oct 17, 2024

I tried to add a multiday event to the calendar so that folks can see the devedmonton hackathon but it's not quite showing up as expected.

The google calendar and the https://devedmonton.com/api/events shown here.
image

The event doesn't seem to show up
image

I know @keifererikson might know a little bit about this.

As a temporary measure I'll just make three separate events here :)

Note references: #312

@keifererikson
Copy link
Contributor

@charrde with the quick fix! Thanks for that!

@dgmouris another win for Open Source Club! 😻 Let's go!

@dgmouris
Copy link
Collaborator Author

@charrde thanks a bunch this looks great!

@keifererikson yay open source club wins!

@dgmouris
Copy link
Collaborator Author

So we merged the above but there's a minor issue that's still happening around the dates it's making the dates 5pm rather than 12am to 12am #419 (comment)

We can take a look at this a few ways but I don't want to close this comment until this is done.

@Atremblay9
Copy link
Contributor

Found some documentation in Vue-Cal for Timeless events: https://antoniandre.github.io/vue-cal/#ex--timeless-events and for min max dates: https://antoniandre.github.io/vue-cal/#ex--min-max-dates

@Atremblay9
Copy link
Contributor

Another solution for multiDay events is the All Day prop: https://antoniandre.github.io/vue-cal/#ex--all-day-events

@dgmouris dgmouris reopened this Oct 18, 2024
@johnjovero98
Copy link
Contributor

johnjovero98 commented Oct 23, 2024

Another bug on multiday event

I suddenly encountered this bug on the events page while working on the calendar.
The multiday event (Develop Ed Hackathon) does not start and end at the right day on the website.

379403509-53a6aacb-b402-479d-88db-92a51fcc5bc1

My best guess would be that without the "timeZone: ..." declared under the "start: {...}" and "end: {...}" dictionary 👀, it will default to GMT 0.

It's kinda like declaring the "start.date" and "end.date" as:

"2024-11-08T00:00-00:00"
"2024-11-11T00:00-00:00"

Though the client side renders datetime in GMT -07 (mountain time) (probably because of our system settings?). Hence, the weird 5pm–5pm and the shift backwards on the days.

console view:
image
image

I think this is an awesome problem to solve at open source club @dgmouris 👀

(P.S. datetimes does make a developer go craaazzehhhh!
Not to mention we are dealing with this as daylight saving is approaching🤯😵‍💫)

@MandyMeindersma
Copy link
Contributor

When I was an intern I broke quickbooks for all of australia because of time zones and my coworkers showed me this video:

https://www.youtube.com/watch?v=-5wpm-gesOY

Wait until 6:35 ish, it's so worth it I promise hahaha

@charrde
Copy link
Contributor

charrde commented Oct 23, 2024

I've actually been working with timezones recently, and seeing this pop up again in my email. I do have a potential fix that appears to be working.

this is the patch I used for making them appear on the calendar recently, it's just an or statement.

event.start.dateTime || event.start.date,
event.end.dateTime || event.end.date,

Replacing it with the below makes it end on the correct date... and makes the weekly calendar look less funky.

(event.start.dateTime || `${event.start.date}T00:00:00`),
(event.end.dateTime || `${event.end.date}T23:59:59`),

I believe this will work okay because from what I can see date is being used for events that are considered all day.

Another bug on multiday event

I suddenly encountered this bug on the events page while working on the calendar. The multiday event (Develop Ed Hackathon) does not start and end at the right day on the website.

379403509-53a6aacb-b402-479d-88db-92a51fcc5bc1

My best guess would be that without the "timeZone: ..." declared under the "start: {...}" and "end: {...}" dictionary 👀, it will default to GMT 0.

It's kinda like declaring the "start.date" and "end.date" as:

"2024-11-08T00:00-00:00" "2024-11-11T00:00-00:00"

Though the client side renders datetime in GMT -07 (mountain time) (probably because of our system settings?). Hence, the weird 5pm–5pm and the shift backwards on the days.

console view: image image

I think this is an awesome problem to solve at open source club @dgmouris 👀

(P.S. datetimes does make a developer go craaazzehhhh! Not to mention we are dealing with this as daylight saving is approaching🤯😵‍💫)

@johnjovero98
Copy link
Contributor

When I was an intern I broke quickbooks for all of australia because of time zones and my coworkers showed me this video:

OMG!!!!! I hope the australian businesses did not miss their tax and ASIC filing dates 😂

https://www.youtube.com/watch?v=-5wpm-gesOY

Imagine if we were a type 3 civilization, and you got a call from another planet hahaha.

One of my instructors mentioned that datetimes are also her pet peeve.
They are very tricky to deal with!

@johnjovero98
Copy link
Contributor

@charrde I tested it on my local repo and it works! I think that's an elegant fix! 👌

I over thought about solving this using unix epoch 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants