Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DES-201: add a YouTube-like event bar #432

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

vyneer
Copy link
Contributor

@vyneer vyneer commented Mar 12, 2024

This PR adds a YouTube-like event bar for subs/donos. The messages stay in the bar for an amount of time that corresponds to the amount of money spent (the exact ratio can be set in the website config, see https://github.com/destinygg/website-private/pull/273). You can see when the event will decay by checking its progress-bar background.

image

Clicking on the event expands it, showing its details.

image

The events get added to the bar in the opposite order that they're received (latest ones go first/to the left). I experimented with sorting the events based on the percentage left instead (higher percentage goes first/to the left), but I found the UX to be annoying - sometimes I clicked on one event, only to find chat highlighting another, since it sorted them before I clicked right underneath my cursor. Another issue with that approach was event positions flipping back and forth in rapid succession if they're close in percentages, but decay at slightly different rates.

Some videos showing the bar in action:

Simple donation
2024-03-12.19-01-38.mp4
Interaction with pinned messages
2024-03-12.19-02-19.mp4

To prevent overcrowding of the UI, the expanded/highlighted event temporarily hides the pinned message UI.

Showing persistence
2024-03-12.19-03-06.mp4
Multiple donations
2024-03-12.19-04-32.mp4
Regular subscription
2024-03-12.19-41-30.mp4
Gifted subscription
2024-03-12.19-42-12.mp4
Mass gift
2024-03-12.19-50-44.mp4

Mass gifts only add one event to the bar (the main one), and not every single following sub.

Handling long usernames
2024-03-12.20-45-31.mp4

If a username is a bit too long (>=12 characters), instead of filling the entire bar, it will scroll back and forth within its container.

This PR needs https://github.com/destinygg/website-private/pull/273 and https://github.com/destinygg/chat-private/pull/48 to work.

@vyneer vyneer added the enhancement New feature or request label Mar 12, 2024
@vyneer vyneer requested a review from 11k March 12, 2024 17:58
11k
11k previously approved these changes Jul 23, 2024
@11k 11k dismissed their stale review July 23, 2024 22:09

HE MISAPPROVED OMEGALUL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants