Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watching Focus #338

Merged
merged 5 commits into from
Dec 5, 2023
Merged

Watching Focus #338

merged 5 commits into from
Dec 5, 2023

Conversation

Mitchdev
Copy link
Contributor

No description provided.

@Mitchdev Mitchdev added the enhancement New feature or request label Sep 19, 2023
@Mitchdev Mitchdev requested a review from 11k September 19, 2023 06:25
Copy link
Contributor

@11k 11k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a popover to the watching focus button with a brief explanation of what it does? Something succinct that tries to convey the behavior to a new user. I came up with "highlight messages from users watching the same stream".

assets/chat/js/messages/ChatUserMessage.js Outdated Show resolved Hide resolved
@Mitchdev Mitchdev requested a review from 11k December 3, 2023 10:31
Copy link
Contributor

@11k 11k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that production builds of our chat JS increased in size by about 240KiB thanks to Bootstrap. While bundle size isn't something we cared about in the past, I think we should care a little in this case. Considering all we need it tooltips, how about using a library like Tippy.js instead?

@Mitchdev Mitchdev requested a review from 11k December 5, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants