Split up the css into separate files #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyneer
force-pushed
the
refactor/css-split
branch
from
4f89e8a
to
a87c348
Compare
11k
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #235
Splits up style.scss into multiple scss files based on the corresponding .js file. For styles that are referenced in multiple files I went with either the one that mentions the style first, or, uh, idk, the one that made the most sense to me 😄There are a couple exceptions:- some common styles are in files named 'common.scss'- on-stream chat is in a separate file because it's just a lot of stuff there, and I didn't want to make the already crowded 'chat.scss' even more bloatedMost styles were just copypasted into their respective files, however sometimes I cleaned things up by using some cool Sass tricks (&, each, etc.). Should, for the most part, compile to identical css as before.Making this a draft since I'm worried I messed something up by changing things, and, also, maybe there are better ways to split some styles up.Remade the PR from scratch to make it resemble the website's CSS structure.